[quantization] Enabling inplace relu #28710
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
does this work? why do we put this assert in the beginning? |
jerryzh168
approved these changes
Oct 25, 2019
Author
Because we didn't support inplace initially, and there was a similar assertion in the functional.relu. After enabling the inplace, the assertion was never lifted in the module (only in the functional) |
Contributor
soumith
pushed a commit
that referenced
this pull request
Nov 4, 2019
Summary: Pull Request resolved: #28710 Test Plan: Imported from OSS Differential Revision: D18146120 Pulled By: z-a-f fbshipit-source-id: d8f0982f5a2ae35f7deb34e67cdb64be700a9d6c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D18146120