[jni][android] Subscribe for record function and if android do atrace #28708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 14, 2019
Summary: ghstack-source-id: 5edaf47 Pull Request resolved: #28708 Some cpp formatting changes as I run `clang-format -i` Testing on devserver: make assets (models): ``` pushd android/test_app/; python make_assets.py; popd ``` Build test_app apk: ``` TRACE_ENABLED=1 sh android/build_test_app.sh find . -type f -name *apk ./android/test_app/app/build/outputs/apk/mobNet2Quant/debug/test_app-mobNet2Quant-debug.apk ./android/test_app/app/build/outputs/apk/resnet18/debug/test_app-resnet18-debug.apk ``` Install apk: `adb install -r test_app-mobNet2Quant-debug.apk` Run app on the device. Systrace: ``` $ANDROID_HOME/platform-tools/systrace/systrace.py -t 10 -a org.pytorch.testapp.mobNet2Quant sched freq idle am wm gfx view binder_driver hal dalvik camera input res -o trace.html ``` trace.html contains sections like `jni::Module::forward`  Pull Request resolved: #28712 Differential Revision: D18495898 Pulled By: IvanKobzarev fbshipit-source-id: 0bced4a442f9dd90525520972a2c1f5d51f57df3
csarofeen
pushed a commit
to mruberry/pytorch
that referenced
this pull request
Nov 18, 2019
Summary: ghstack-source-id: 5edaf47 Pull Request resolved: pytorch#28708 Some cpp formatting changes as I run `clang-format -i` Testing on devserver: make assets (models): ``` pushd android/test_app/; python make_assets.py; popd ``` Build test_app apk: ``` TRACE_ENABLED=1 sh android/build_test_app.sh find . -type f -name *apk ./android/test_app/app/build/outputs/apk/mobNet2Quant/debug/test_app-mobNet2Quant-debug.apk ./android/test_app/app/build/outputs/apk/resnet18/debug/test_app-resnet18-debug.apk ``` Install apk: `adb install -r test_app-mobNet2Quant-debug.apk` Run app on the device. Systrace: ``` $ANDROID_HOME/platform-tools/systrace/systrace.py -t 10 -a org.pytorch.testapp.mobNet2Quant sched freq idle am wm gfx view binder_driver hal dalvik camera input res -o trace.html ``` trace.html contains sections like `jni::Module::forward`  Pull Request resolved: pytorch#28712 Differential Revision: D18495898 Pulled By: IvanKobzarev fbshipit-source-id: 0bced4a442f9dd90525520972a2c1f5d51f57df3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack: