Support remote for Python UDF in distributed autograd #28656
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
[ghstack-poisoned]
Contributor
|
overall lgtm, same comments as #28630 |
Differential Revision: [D18138561](https://our.internmc.facebook.com/intern/diff/D18138561) [ghstack-poisoned]
mrshenli
added a commit
to mrshenli/pytorch
that referenced
this pull request
Oct 28, 2019
ghstack-source-id: a497929 Pull Request resolved: pytorch#28656
Differential Revision: [D18138561](https://our.internmc.facebook.com/intern/diff/D18138561) [ghstack-poisoned]
Differential Revision: [D18138561](https://our.internmc.facebook.com/intern/diff/D18138561) [ghstack-poisoned]
Contributor
Author
|
Created #28819 to track the coverage on a corner case. |
Differential Revision: [D18138561](https://our.internmc.facebook.com/intern/diff/D18138561) [ghstack-poisoned]
Differential Revision: [D18138561](https://our.internmc.facebook.com/intern/diff/D18138561) [ghstack-poisoned]
Differential Revision: [D18138561](https://our.internmc.facebook.com/intern/diff/D18138561) [ghstack-poisoned]
Differential Revision: [D18138561](https://our.internmc.facebook.com/intern/diff/D18138561) [ghstack-poisoned]
Differential Revision: [D18138561](https://our.internmc.facebook.com/intern/diff/D18138561) [ghstack-poisoned]
pritamdamania87
approved these changes
Oct 29, 2019
Differential Revision: [D18138561](https://our.internmc.facebook.com/intern/diff/D18138561) [ghstack-poisoned]
Contributor
Contributor
|
@mrshenli I think Can you please decide if you want to revert this land. |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D18138561