Fix when giving jit format warning about unsupported options #28616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D18039443 |
ggoossen
force-pushed
the
export-D18039443
branch
from
a9204d5 to
493fff2
Compare
ggoossen
force-pushed
the
export-D18039443
branch
from
493fff2 to
11a01cd
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D18039443 |
soumith
approved these changes
Oct 24, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ggoossen is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
…#28616) Summary: Current reges also matches strings with '{}' so warning is always given. Pull Request resolved: pytorch#28616 Test Plan: Previous code was giving a warning about unspported options, these disappeared. When adding something inside '{}' the warning came back. Differential Revision: D18039443 Pulled By: ggoossen fbshipit-source-id: ee926d6d5ab149d979106e00a3e7d1f8c24a13fc
ggoossen
force-pushed
the
export-D18039443
branch
from
11a01cd to
1cca940
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D18039443 |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ggoossen is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
ggoossen
added a commit
that referenced
this pull request
Nov 5, 2019
…attempt Previous attempt in #28616 didn't work in clang8 and got reverted in #28916 This one escapes the } inside the brackets, maybe that works Differential Revision: [D18324286](https://our.internmc.facebook.com/intern/diff/D18324286/) [ghstack-poisoned]
ggoossen
added a commit
that referenced
this pull request
Nov 5, 2019
…attempt Previous attempt in #28616 didn't work in clang8 and got reverted in #28916 This one escapes the } inside the brackets, maybe that works Differential Revision: [D18324286](https://our.internmc.facebook.com/intern/diff/D18324286/) ghstack-source-id: 93270628 Pull Request resolved: #29193
ggoossen
added a commit
that referenced
this pull request
Nov 5, 2019
…ns, second attempt" Previous attempt in #28616 didn't work in clang8 and got reverted in #28916 This one escapes the } inside the brackets, maybe that works Differential Revision: [D18324286](https://our.internmc.facebook.com/intern/diff/D18324286/) [ghstack-poisoned]
ggoossen
added a commit
that referenced
this pull request
Nov 5, 2019
…attempt Pull Request resolved: #29193 Previous attempt in #28616 didn't work in clang8 and got reverted in #28916 This one escapes the } inside the brackets, maybe that works ghstack-source-id: 93283014 Differential Revision: [D18324286](https://our.internmc.facebook.com/intern/diff/D18324286/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Current reges also matches strings with '{}' so warning is always given.
Test Plan: Previous code was giving a warning about unspported options, these disappeared. When adding something inside '{}' the warning came back.
Differential Revision: D18039443