addmm: Fix handling of case with empty tensor #28613
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: addmm: Fix handling of case with empty tensor. Currently these cause an error Recreation of D18085389 without stacked diffs Test Plan: test included Differential Revision: D18122004 fbshipit-source-id: 74f1ee40d64a365205ed5b4f8a421a329c88c3a6
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D18122004 |
Collaborator
Contributor
Author
|
@zasdfgbnm yes this fixes #27619 |
gchanan
approved these changes
Oct 25, 2019
Contributor
|
This pull request has been merged in c60dee2. |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 28, 2019
Summary: Pull Request resolved: pytorch/pytorch#28613 addmm: Fix handling of case with empty tensor. Currently these cause an error Recreation of D18085389 without stacked diffs Test Plan: test included Differential Revision: D18122004 fbshipit-source-id: 71513c02ace691902553bea5ce9dc2538cca4c99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
addmm: Fix handling of case with empty tensor.
Currently these cause an error
Recreation of D18085389 without stacked diffs
Test Plan: test included
Differential Revision: D18122004