Define std::strtoll for older Android #28603
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Plan: CI Differential Revision: D18099518 fbshipit-source-id: e27611c9b52f20eff19ca50dba6a27d682d90e03
Summary: This isn't used anywhere, and it doesn't work with older libstdc++ because std::ostringstream is not copyable or movable. Test Plan: Internal android build. Differential Revision: D18099511 fbshipit-source-id: ecf56351aebb6f9e29bd64f5d30b363d5db2a6db
Summary:
This was added because std::to_string isn't available in libstc++
on Android. Use it in more places to get the PyTorch Android
build working with libstdc++.
Test Plan:
`buck build -c project.ignore= @//fbandroid/mode/server //xplat/experimental/pytorch/predictor:predictorAndroid#android-arm{v7,64}`
(After some more diffs in this stack.)
Differential Revision: D18099520
fbshipit-source-id: 550487d288d13dc3612f0b722cd37f96ea17a109
Summary: This symbol isn't availble in older Android configs, so import it from the global namespace in the same file as the rest of our Android string compatibility hacks. Test Plan: Internal android build. Reviewed By: jerryzh168 Differential Revision: D18099515 fbshipit-source-id: 31dda4ce01f9186f192134de80d1798cb4364c26
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D18099515 |
facebook-github-bot
added
the
oncall: jit
Contributor
|
This pull request has been merged in 1dfb875. |
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: Pull Request resolved: pytorch#28603 This symbol isn't availble in older Android configs, so import it from the global namespace in the same file as the rest of our Android string compatibility hacks. Test Plan: Internal android build. Reviewed By: jerryzh168 Differential Revision: D18099515 fbshipit-source-id: f8b0c80ea7344e05975a695afb359b339b6d9404
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This symbol isn't availble in older Android configs, so import it
from the global namespace in the same file as the rest of our
Android string compatibility hacks.
Test Plan: Internal android build.
Reviewed By: jerryzh168
Differential Revision: D18099515