Introduce math_compat.h for older Android versions #28567
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
oncall: jit
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D18099513 |
dreiss
force-pushed
the
export-D18099513
branch
from
1f39782 to
70145ba
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D18099513 |
Contributor
Author
|
@gchanan , any concerns with the include in THNN/SoftPlus? |
gchanan
approved these changes
Oct 31, 2019
Summary: Pull Request resolved: pytorch#28567 When building with Android NDK platforms prior to android-21, and when building for Android with libstdc++, there are some gaps in the C and C++ standard libraries. We use both for our internal 32-bit builds, so we need PyTorch to support this platform. All of the gaps are filled with this math_compat.h header, which needs to be included in any file that uses one of the functions that are not properly defined on Android. The file is a bit hack-tastic, but it is only used on a platform that is not receiving updates, so there shouldn't be a risk of breakage in the future. Test Plan: Internal android build. Differential Revision: D18099513 fbshipit-source-id: 253b6e5ea4677741f6caed28de708128f4e0913c
dreiss
force-pushed
the
export-D18099513
branch
from
70145ba to
a50c2a5
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D18099513 |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@dreiss is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Nov 5, 2019
Summary: When building with Android NDK platforms prior to android-21, and when building for Android with libstdc++, there are some gaps in the C and C++ standard libraries. We use both for our internal 32-bit builds, so we need PyTorch to support this platform. All of the gaps are filled with this math_compat.h header, which needs to be included in any file that uses one of the functions that are not properly defined on Android. The file is a bit hack-tastic, but it is only used on a platform that is not receiving updates, so there shouldn't be a risk of breakage in the future. Pull Request resolved: pytorch/pytorch#28567 Test Plan: Internal android build. Differential Revision: D18099513 Pulled By: dreiss fbshipit-source-id: 020aab19c6fa083206310b018925d92275d4a548
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When building with Android NDK platforms prior to android-21,
and when building for Android with libstdc++, there are some
gaps in the C and C++ standard libraries. We use both for our
internal 32-bit builds, so we need PyTorch to support this platform.
All of the gaps are filled with this math_compat.h header, which
needs to be included in any file that uses one of the functions
that are not properly defined on Android. The file is a bit
hack-tastic, but it is only used on a platform that is not receiving
updates, so there shouldn't be a risk of breakage in the future.
Test Plan: Internal android build.
Differential Revision: D18099513