Add torch.memory_format support to the TorchScript #28544
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Oct 23, 2019
facebook-github-bot
added
the
oncall: jit
…"Add torch.memory_format support to the TorchScript" Differential Revision: [D18093801](https://our.internmc.facebook.com/intern/diff/D18093801) [ghstack-poisoned]
… TorchScript" Differential Revision: [D18093801](https://our.internmc.facebook.com/intern/diff/D18093801) [ghstack-poisoned]
Closed
…mat support to the TorchScript" Differential Revision: [D18093801](https://our.internmc.facebook.com/intern/diff/D18093801) [ghstack-poisoned]
Differential Revision: [D18093801](https://our.internmc.facebook.com/intern/diff/D18093801) [ghstack-poisoned]
zdevito
reviewed
Oct 31, 2019
Contributor
zdevito
left a comment
zdevito
left a comment
There was a problem hiding this comment.
It's hard to know if this is correct without tests, but the code looks simple enough.
Contributor
|
Yeah a test, or even just some basic indication how you figured out this was working (e.g., does a later PR exercise it?) would be great. |
…orchScript" Differential Revision: [D18093801](https://our.internmc.facebook.com/intern/diff/D18093801) [ghstack-poisoned]
Differential Revision: [D18093801](https://our.internmc.facebook.com/intern/diff/D18093801) [ghstack-poisoned]
This was referenced Nov 8, 2019
Closed
…hScript" Differential Revision: [D18093801](https://our.internmc.facebook.com/intern/diff/D18093801) [ghstack-poisoned]
…the TorchScript" Differential Revision: [D18093801](https://our.internmc.facebook.com/intern/diff/D18093801) [ghstack-poisoned]
Differential Revision: [D18093801](https://our.internmc.facebook.com/intern/diff/D18093801) [ghstack-poisoned]
Differential Revision: [D18093801](https://our.internmc.facebook.com/intern/diff/D18093801) [ghstack-poisoned]
…ript" Differential Revision: [D18093801](https://our.internmc.facebook.com/intern/diff/D18093801) [ghstack-poisoned]
Differential Revision: [D18093801](https://our.internmc.facebook.com/intern/diff/D18093801) [ghstack-poisoned]
Contributor
Author
|
Test added |
…he TorchScript" Differential Revision: [D18093801](https://our.internmc.facebook.com/intern/diff/D18093801) [ghstack-poisoned]
Differential Revision: [D18093801](https://our.internmc.facebook.com/intern/diff/D18093801) [ghstack-poisoned]
zdevito
approved these changes
Nov 12, 2019
Differential Revision: [D18093801](https://our.internmc.facebook.com/intern/diff/D18093801) [ghstack-poisoned]
Differential Revision: [D18093801](https://our.internmc.facebook.com/intern/diff/D18093801) [ghstack-poisoned]
…cript" Differential Revision: [D18093801](https://our.internmc.facebook.com/intern/diff/D18093801) [ghstack-poisoned]
…cript" Differential Revision: [D18093801](https://our.internmc.facebook.com/intern/diff/D18093801) [ghstack-poisoned]
…cript" Differential Revision: [D18093801](https://our.internmc.facebook.com/intern/diff/D18093801) [ghstack-poisoned]
Contributor
|
@VitalyFedyunin merged this pull request in 5f51037. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
resize_op. #28292 Add memory format support to theresize_op.operator==of TensorOptions as confusing one #28076 Killoperator==of TensorOptions as confusing oneresize_as_operator #27979 Add memory format support toresize_as_operatorDifferential Revision: D18093801