[ONNX] Fixed export for random #28470
Conversation
|
@pytorchbot rebase this please |
torch/onnx/symbolic_opset9.py
Outdated
| return g.op('RandomNormalLike', self) | ||
|
|
||
|
|
||
| def rand_like(g, self, *others): |
There was a problem hiding this comment.
one of the args of these ops is dtype.
Can you add a Cast when necessary to make sure to match the desired type?
And maybe change one of the tests to set the dtype for a type other than float.
There was a problem hiding this comment.
Sure. Double was another type supported by torch.rand_like. I've added tests for that.
|
@lara-hdr can you please approve? |
|
@neginraoof can you please merge this? |
|
cc @houseroad this PR is approved and ready. |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@houseroad is there a related failure? |
|
@houseroad merged this pull request in 364e525. |
|
This PR was reverted since it broke CIs. Could you resubmit the PR @neginraoof ? |
6 participants
[ONNX] Fixed export for random generator ops