[iOS] Scripts for setting up benchmark projects #28469
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Summary As described [here](#28405), This PR is the second one that contains scripts for setting up the benchmark projects. ### Test Plan Don't break CI jobs unless they are flaky.
### Summary As described [here](#28405), This PR is the second one that contains scripts for setting up the benchmark projects. ### Test Plan Don't break CI jobs unless they are flaky.
ljk53
reviewed
Oct 23, 2019
ios/TestApp/benchmark/setup.rb
Outdated
Comment on lines
31
to
36
| model_path_src = File.expand_path("./model.pt") | ||
| model_path_dst = File.expand_path("../model.pt") | ||
| if not File.exist?(model_path_src) | ||
| raise "no model can be found!" | ||
| end | ||
| FileUtils.cp(model_path_src, model_path_dst) |
Contributor
There was a problem hiding this comment.
why do we need copy model.pt around? seems a bit confusing to have the same file at both "./" and "../".
can we directly use "TestApp/benchmark/model.pt" from the project? or make "trace_model.py" to save to "TestApp/model.pt" directly?
Contributor
Author
There was a problem hiding this comment.
Let's keep the model in TestApp/benchmark
### Summary As described [here](#28405), This PR is the second one that contains scripts for setting up the benchmark projects. ### Test Plan Don't break CI jobs unless they are flaky.
xta0
added
the
module: ios
ljk53
approved these changes
Oct 23, 2019
Contributor
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: Pull Request resolved: pytorch#28469 ### Summary As described [here](pytorch#28405), This PR is the second one that contains scripts for setting up the benchmark projects. ### Test Plan Don't break CI jobs unless they are flaky. Test Plan: Imported from OSS Differential Revision: D18097248 Pulled By: xta0 fbshipit-source-id: 6f9d1275a07aecae21afd81d5e90a89a75d0270f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary
As described here, This PR is the second one that contains scripts for setting up the benchmark projects.
Test Plan
Don't break CI jobs unless they are flaky.
Differential Revision: D18097248