[jit] guard against inheritance on torchscript classes #28407
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Given that we do not have support for inheitance or any polymorphism strategy yet, we should guard against user from using it until we get the full support so that user won't confuse by the weird behaviors. Test Plan: Reviewers: Subscribers: Tasks: Tags:
This was referenced Oct 22, 2019
facebook-github-bot
added
the
oncall: jit
Summary: Given that we do not have support for inheitance or any polymorphism strategy yet, we should guard against user from using it until we get the full support so that user won't confuse by the weird behaviors. Test Plan: Reviewers: Subscribers: Tasks: Tags:
… classes" Summary: Given that we do not have support for inheitance or any polymorphism strategy yet, we should guard against user from using it until we get the full support so that user won't confuse by the weird behaviors. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
zdevito
approved these changes
Oct 23, 2019
Contributor
zdevito
left a comment
zdevito
left a comment
There was a problem hiding this comment.
Looks good, small phrasing comment.
torch/jit/__init__.py
Outdated
| raise RuntimeError("TorchScript classes must be new-style classes. " | ||
| "Please inherit from 'object'") | ||
| if len(obj.mro()) > 2: | ||
| raise RuntimeError("TorchScript classes does not support inheritance or any polymorphism strategy yet. " |
Contributor
There was a problem hiding this comment.
"or any polymorphism strategy" is not correct. Interfaces are a form of polymorphism. The first part of the message is fine.
torch/jit/__init__.py
Outdated
| "Please inherit from 'object'") | ||
| if len(obj.mro()) > 2: | ||
| raise RuntimeError("TorchScript classes does not support inheritance or any polymorphism strategy yet. " | ||
| "Please directly inherit from 'object'. File a issue if you want this. ") |
Contributor
There was a problem hiding this comment.
Let's keep 'File an issue' for bugs only. It implies implementing this would be easy when it is in face very difficult, which is why we haven't implemented it.
Summary: Given that we do not have support for inheitance or any polymorphism strategy yet, we should guard against user from using it until we get the full support so that user won't confuse by the weird behaviors. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Given that we do not have support for inheitance or any polymorphism strategy yet, we should guard against user from using it until we get the full support so that user won't confuse by the weird behaviors. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Given that we do not have support for inheitance or any polymorphism strategy yet, we should guard against user from using it until we get the full support so that user won't confuse by the weird behaviors. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Given that we do not have support for inheitance or any polymorphism strategy yet, we should guard against user from using it until we get the full support so that user won't confuse by the weird behaviors. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Given that we do not have support for inheitance or any polymorphism strategy yet, we should guard against user from using it until we get the full support so that user won't confuse by the weird behaviors. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Given that we do not have support for inheitance or any polymorphism strategy yet, we should guard against user from using it until we get the full support so that user won't confuse by the weird behaviors. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Given that we do not have support for inheitance or any polymorphism strategy yet, we should guard against user from using it until we get the full support so that user won't confuse by the weird behaviors. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Given that we do not have support for inheitance or any polymorphism strategy yet, we should guard against user from using it until we get the full support so that user won't confuse by the weird behaviors. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D18284310](https://our.internmc.facebook.com/intern/diff/D18284310) [ghstack-poisoned]
Contributor
|
This pull request has been merged in 1e90404. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Given that we do not have support for inheitance or any polymorphism
strategy yet, we should guard against user from using it until we get
the full support so that user won't confuse by the weird behaviors.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D18284310