[jit] fix @property #28395
Closed
[jit] fix @property #28395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `@property` methods are broken in TorchScript because we basically treat it as an attribute in the existing path: we'll evaluate the method once and store that as the value forever. This PR fixes it so that `@property` actually behaves correctly: 1. Added `properties` as part of `ConcreteModuleType`. 2. Added a `PropertyValue` `SugaredValue` that behaves exactly like a method but it can be used as a value. 3. `ModuleValue::attr` now checks wheter a method is a property, and returns a `PropertyValue` if so. This approach has the disadvantage of making `ModuleValue` more special. But it has the advantage of not leaking the concept of properties deeper into the type system.
suo
added a commit
that referenced
this pull request
Oct 22, 2019
Currently `@property` methods are broken in TorchScript because we basically treat it as an attribute in the existing path: we'll evaluate the method once and store that as the value forever. This PR fixes it so that `@property` actually behaves correctly: 1. Added `properties` as part of `ConcreteModuleType`. 2. Added a `PropertyValue` `SugaredValue` that behaves exactly like a method but it can be used as a value. 3. `ModuleValue::attr` now checks wheter a method is a property, and returns a `PropertyValue` if so. This approach has the disadvantage of making `ModuleValue` more special. But it has the advantage of not leaking the concept of properties deeper into the type system. ghstack-source-id: a13523d Pull Request resolved: #28395
facebook-github-bot
added
the
oncall: jit
Currently `@property` methods are broken in TorchScript because we basically treat it as an attribute in the existing path: we'll evaluate the method once and store that as the value forever. This PR fixes it so that `@property` actually behaves correctly: 1. Added `properties` as part of `ConcreteModuleType`. 2. Added a `PropertyValue` `SugaredValue` that behaves exactly like a method but it can be used as a value. 3. `ModuleValue::attr` now checks wheter a method is a property, and returns a `PropertyValue` if so. This approach has the disadvantage of making `ModuleValue` more special. But it has the advantage of not leaking the concept of properties deeper into the type system. Differential Revision: [D18054946](https://our.internmc.facebook.com/intern/diff/D18054946)
Currently `@property` methods are broken in TorchScript because we basically treat it as an attribute in the existing path: we'll evaluate the method once and store that as the value forever. This PR fixes it so that `@property` actually behaves correctly: 1. Added `properties` as part of `ConcreteModuleType`. 2. Added a `PropertyValue` `SugaredValue` that behaves exactly like a method but it can be used as a value. 3. `ModuleValue::attr` now checks wheter a method is a property, and returns a `PropertyValue` if so. This approach has the disadvantage of making `ModuleValue` more special. But it has the advantage of not leaking the concept of properties deeper into the type system. Differential Revision: [D18054946](https://our.internmc.facebook.com/intern/diff/D18054946)
Currently `@property` methods are broken in TorchScript because we basically treat it as an attribute in the existing path: we'll evaluate the method once and store that as the value forever. This PR fixes it so that `@property` actually behaves correctly: 1. Added `properties` as part of `ConcreteModuleType`. 2. Added a `PropertyValue` `SugaredValue` that behaves exactly like a method but it can be used as a value. 3. `ModuleValue::attr` now checks wheter a method is a property, and returns a `PropertyValue` if so. This approach has the disadvantage of making `ModuleValue` more special. But it has the advantage of not leaking the concept of properties deeper into the type system. Differential Revision: [D18054946](https://our.internmc.facebook.com/intern/diff/D18054946)
suo
added a commit
that referenced
this pull request
Oct 24, 2019
Currently `@property` methods are broken in TorchScript because we basically treat it as an attribute in the existing path: we'll evaluate the method once and store that as the value forever. Since lack of `@property` support is easily worked around (just make it a method), I've opted to just explicitly error to avoid confusion. If people want it, they can file an issue and we can look at their use case. This also helps us nicely clean up some parts of the ScriptModule conversion path. ghstack-source-id: d318663 Pull Request resolved: #28395
zdevito
approved these changes
Oct 28, 2019
torch/jit/_recursive.py
Outdated
| # original function => [(mangled overload name, overload function)] | ||
| overloads = {} | ||
|
|
||
| # TODO: should this be dir(type(mod))? |
Currently `@property` methods are broken in TorchScript because we basically treat it as an attribute in the existing path: we'll evaluate the method once and store that as the value forever. Since lack of `@property` support is easily worked around (just make it a method), I've opted to just explicitly error to avoid confusion. If people want it, they can file an issue and we can look at their use case. This also helps us nicely clean up some parts of the ScriptModule conversion path. Pull Request resolved: #28395 Differential Revision: [D18054946](https://our.internmc.facebook.com/intern/diff/D18054946)
suo
added a commit
that referenced
this pull request
Nov 7, 2019
Currently `@property` methods are broken in TorchScript because we basically treat it as an attribute in the existing path: we'll evaluate the method once and store that as the value forever. Since lack of `@property` support is easily worked around (just make it a method), I've opted to just explicitly error to avoid confusion. If people want it, they can file an issue and we can look at their use case. This also helps us nicely clean up some parts of the ScriptModule conversion path. Pull Request resolved: #28395 Differential Revision: [D18054946](https://our.internmc.facebook.com/intern/diff/D18054946)
Member
CircleCI build failures summaryAs of commit 2fe2634:
Here are the reasons each build failed. This comment was automatically generated by Dr. CI. Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 3 time(s). |
Currently `@property` methods are broken in TorchScript because we basically treat it as an attribute in the existing path: we'll evaluate the method once and store that as the value forever. Since lack of `@property` support is easily worked around (just make it a method), I've opted to just explicitly error to avoid confusion. If people want it, they can file an issue and we can look at their use case. This also helps us nicely clean up some parts of the ScriptModule conversion path. Pull Request resolved: #28395 Differential Revision: [D18054946](https://our.internmc.facebook.com/intern/diff/D18054946)
suo
added a commit
that referenced
this pull request
Nov 7, 2019
Currently `@property` methods are broken in TorchScript because we basically treat it as an attribute in the existing path: we'll evaluate the method once and store that as the value forever. Since lack of `@property` support is easily worked around (just make it a method), I've opted to just explicitly error to avoid confusion. If people want it, they can file an issue and we can look at their use case. This also helps us nicely clean up some parts of the ScriptModule conversion path. Pull Request resolved: #28395 Differential Revision: [D18054946](https://our.internmc.facebook.com/intern/diff/D18054946)
Currently `@property` methods are broken in TorchScript because we basically treat it as an attribute in the existing path: we'll evaluate the method once and store that as the value forever. Since lack of `@property` support is easily worked around (just make it a method), I've opted to just explicitly error to avoid confusion. If people want it, they can file an issue and we can look at their use case. This also helps us nicely clean up some parts of the ScriptModule conversion path. Pull Request resolved: #28395 Differential Revision: [D18054946](https://our.internmc.facebook.com/intern/diff/D18054946)
suo
added a commit
that referenced
this pull request
Nov 7, 2019
Currently `@property` methods are broken in TorchScript because we basically treat it as an attribute in the existing path: we'll evaluate the method once and store that as the value forever. Since lack of `@property` support is easily worked around (just make it a method), I've opted to just explicitly error to avoid confusion. If people want it, they can file an issue and we can look at their use case. This also helps us nicely clean up some parts of the ScriptModule conversion path. Pull Request resolved: #28395 Differential Revision: [D18054946](https://our.internmc.facebook.com/intern/diff/D18054946)
suo
added a commit
that referenced
this pull request
Nov 7, 2019
Currently `@property` methods are broken in TorchScript because we basically treat it as an attribute in the existing path: we'll evaluate the method once and store that as the value forever. Since lack of `@property` support is easily worked around (just make it a method), I've opted to just explicitly error to avoid confusion. If people want it, they can file an issue and we can look at their use case. This also helps us nicely clean up some parts of the ScriptModule conversion path. ghstack-source-id: 7ea6dab Pull Request resolved: #28395
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Currently
@propertymethods are broken in TorchScript because webasically treat it as an attribute in the existing path: we'll evaluate
the method once and store that as the value forever.
Since lack of
@propertysupport is easily worked around (just make ita method), I've opted to just explicitly error to avoid confusion. If
people want it, they can file an issue and we can look at their use
case.
This also helps us nicely clean up some parts of the ScriptModule conversion
path.
Pull Request resolved: #28395
Differential Revision: D18054946