Do not insert observers for empty sequential modules #28384
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: [D18047293](https://our.internmc.facebook.com/intern/diff/D18047293/) [ghstack-poisoned]
hx89
reviewed
Oct 21, 2019
torch/quantization/quantize.py
Outdated
| len(module._modules) == 0 and not isinstance(module, torch.nn.Sequential): | ||
| # observer and hook will be gone after we swap the module | ||
| module.add_module('activation_post_process', module.qconfig.activation()) | ||
| module.register_forward_hook(_observer_forward_hook) |
Contributor
Author
There was a problem hiding this comment.
Thanks, fixed now
Differential Revision: [D18047293](https://our.internmc.facebook.com/intern/diff/D18047293/) [ghstack-poisoned]
raghuramank100
pushed a commit
that referenced
this pull request
Oct 21, 2019
Pull Request resolved: #28384 ghstack-source-id: 92320323 Differential Revision: [D18047293](https://our.internmc.facebook.com/intern/diff/D18047293/)
hx89
approved these changes
Oct 21, 2019
Differential Revision: [D18047293](https://our.internmc.facebook.com/intern/diff/D18047293/) [ghstack-poisoned]
raghuramank100
pushed a commit
that referenced
this pull request
Oct 22, 2019
Pull Request resolved: #28384 ghstack-source-id: 92340259 Differential Revision: [D18047293](https://our.internmc.facebook.com/intern/diff/D18047293/)
lly-zero-one
approved these changes
Oct 22, 2019
Contributor
|
This pull request has been merged in 94757e0. |
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: Pull Request resolved: pytorch#28384 ghstack-source-id: 92340259 Test Plan: buck test caffe2/test:quantization -- 'test_fusion_sequential_model_train \(test_quantization\.FusionTest\)' --print-passing-details buck test caffe2/test:quantization -- 'test_fusion_sequential_model_eval \(test_quantization\.FusionTest\)' --print-passing-details Differential Revision: D18047293 fbshipit-source-id: 7e18b1aa76cc0fd26e8ee48a70c3a45688e73549
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28375
Stack from ghstack:
Differential Revision: D18047293