Skip to content

Conversation

@xta0
Copy link
Contributor

@xta0 xta0 commented Oct 21, 2019

Stack from ghstack:

Summary

I'm working on setting up a benchmark test project for iOS, which will reuse this Fastlane file. This PR removes the "cert install" code from "before_all" to a standalone lane target.

Test Plan

  • don't break any existing CI jobs

Differential Revision: D18053675

@xta0 xta0 changed the title [DO NOT MERGE][IOS][CI] Move install certificate from before_all [DO NOT MERGE][IOS][CI] Move "import_cert" from before_all Oct 21, 2019
xta0 added a commit that referenced this pull request Oct 21, 2019
ghstack-source-id: b347332
Pull Request resolved: #28356
@xta0 xta0 changed the title [DO NOT MERGE][IOS][CI] Move "import_cert" from before_all [DO NOT MERGE][IOS][CI] Fastlane update Oct 21, 2019
@xta0 xta0 changed the title [DO NOT MERGE][IOS][CI] Fastlane update [IOS][CI] Fastlane update Oct 21, 2019
@xta0 xta0 requested review from ezyang, kostmo and ljk53 October 21, 2019 15:53
Copy link
Contributor

@ljk53 ljk53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@facebook-github-bot
Copy link
Contributor

@xta0 merged this pull request in d403410.

@facebook-github-bot facebook-github-bot deleted the gh/xta0/33/head branch October 28, 2019 22:22
thiagocrepaldi pushed a commit to thiagocrepaldi/pytorch that referenced this pull request Feb 4, 2020
Summary:
Pull Request resolved: pytorch#28356

### Summary

I'm working on setting up a benchmark test project for iOS, which will reuse this Fastlane file. This PR removes the "cert install" code from "before_all" to a standalone lane target.

### Test Plan

- don't break any existing CI jobs

Test Plan: Imported from OSS

Differential Revision: D18053675

Pulled By: xta0

fbshipit-source-id: e4760a8494916c410af19ca43f040fc463551d11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants