[pytorch] Minor tweaks to rpc message api #28326
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Message::type() should return a MessageType, not const MessageType&, since MessageType is just an enum. - Add moveTensors() method for parallelism with movePayload(). Differential Revision: [D18021692](https://our.internmc.facebook.com/intern/diff/D18021692/) [ghstack-poisoned]
jjlilley
pushed a commit
that referenced
this pull request
Oct 18, 2019
- Message::type() should return a MessageType, not const MessageType&, since MessageType is just an enum. - Add moveTensors() method for parallelism with movePayload(). Differential Revision: [D18021692](https://our.internmc.facebook.com/intern/diff/D18021692/) ghstack-source-id: 92236443 Pull Request resolved: #28326
mrshenli
approved these changes
Oct 19, 2019
Contributor
|
This pull request has been merged in 6fcefc9. |
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: Pull Request resolved: pytorch#28326 - Message::type() should return a MessageType, not const MessageType&, since MessageType is just an enum. - Add moveTensors() method for parallelism with movePayload(). ghstack-source-id: 92236443 Test Plan: buck test mode/dev-nosan caffe2/test/... Differential Revision: D18021692 fbshipit-source-id: 5b2f5806f104a221de8df0282f3e395d15e5bfe4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
since MessageType is just an enum.
Differential Revision: D18021692