TensroIterator preserve format for binary, ternary operators. #28291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Oct 18, 2019
…rs." [ghstack-poisoned]
…nary operators." [ghstack-poisoned]
…ternary operators." [ghstack-poisoned]
…tors." Differential Revision: [D18044977](https://our.internmc.facebook.com/intern/diff/D18044977) [ghstack-poisoned]
…rs." Differential Revision: [D18044977](https://our.internmc.facebook.com/intern/diff/D18044977) [ghstack-poisoned]
…rmat for binary, ternary operators." Differential Revision: [D18044977](https://our.internmc.facebook.com/intern/diff/D18044977) [ghstack-poisoned]
…"TensroIterator preserve format for binary, ternary operators." Differential Revision: [D18044977](https://our.internmc.facebook.com/intern/diff/D18044977) [ghstack-poisoned]
…ary, ternary operators." Differential Revision: [D18044977](https://our.internmc.facebook.com/intern/diff/D18044977) [ghstack-poisoned]
Closed
…rve format for binary, ternary operators." Differential Revision: [D18044977](https://our.internmc.facebook.com/intern/diff/D18044977) [ghstack-poisoned]
18 tasks
Contributor
Author
|
@ngimel I will add tests and benchmark results, so far I just looking your opinion on structure. |
…ry operators." Differential Revision: [D18044977](https://our.internmc.facebook.com/intern/diff/D18044977) [ghstack-poisoned]
…y, ternary operators." Differential Revision: [D18044977](https://our.internmc.facebook.com/intern/diff/D18044977) [ghstack-poisoned]
… operators." Differential Revision: [D18044977](https://our.internmc.facebook.com/intern/diff/D18044977) [ghstack-poisoned]
This was referenced Nov 8, 2019
Closed
…ternary operators." Differential Revision: [D18044977](https://our.internmc.facebook.com/intern/diff/D18044977) [ghstack-poisoned]
…rators." Differential Revision: [D18044977](https://our.internmc.facebook.com/intern/diff/D18044977) [ghstack-poisoned]
ngimel
reviewed
Nov 11, 2019
| # lambda x, y: x.abs(), # https://github.com/pytorch/pytorch/issues/24531 | ||
| # lambda x, y: x.acos(), # https://github.com/pytorch/pytorch/issues/24532 | ||
| lambda x, y: x.add(y, alpha=3), | ||
| lambda x, y: x.addcdiv(2, y, y), |
Collaborator
There was a problem hiding this comment.
given that y is contiguous, what are we testing here? Should it have been x, y in the arguments (same for addcmul)
Contributor
Author
There was a problem hiding this comment.
Addressed by adding more tests
| op.tensor = at::empty(tensor_shape, op.options()); | ||
| op.tensor.unsafeGetTensorImpl()->empty_tensor_restride( | ||
| MemoryFormat::ChannelsLast); | ||
| op.stride_bytes = apply_perm_and_mul(op.tensor.strides(), element_size); |
Collaborator
There was a problem hiding this comment.
I cannot convince myself that op.stride_bytes and op.tensor.strides() are guaranteed to be consistent (one is defined by perm_ which can be whatever, and the other is hardcoded nhwc), and tests are only testing contiguity of output which is guaranteed by empty_tensor_restride, not its correctness.
Contributor
Author
There was a problem hiding this comment.
Addressed by adding comment
…nary operators." Differential Revision: [D18044977](https://our.internmc.facebook.com/intern/diff/D18044977) [ghstack-poisoned]
…perators." Differential Revision: [D18044977](https://our.internmc.facebook.com/intern/diff/D18044977) [ghstack-poisoned]
…inary, ternary operators." Differential Revision: [D18044977](https://our.internmc.facebook.com/intern/diff/D18044977) [ghstack-poisoned]
… operators." Differential Revision: [D18044977](https://our.internmc.facebook.com/intern/diff/D18044977) [ghstack-poisoned]
ngimel
approved these changes
Nov 12, 2019
…rnary operators." Differential Revision: [D18044977](https://our.internmc.facebook.com/intern/diff/D18044977) [ghstack-poisoned]
…rnary operators." Differential Revision: [D18044977](https://our.internmc.facebook.com/intern/diff/D18044977) [ghstack-poisoned]
…rnary operators." Differential Revision: [D18044977](https://our.internmc.facebook.com/intern/diff/D18044977) [ghstack-poisoned]
Contributor
|
@VitalyFedyunin merged this pull request in a7df369. |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Nov 18, 2019
Summary: Pull Request resolved: pytorch/pytorch#28291 Test Plan: Imported from OSS Differential Revision: D18044977 Pulled By: VitalyFedyunin fbshipit-source-id: 793bab47d8cfc1b0d6229f1b0688352ee94c3e48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
resize_op. #28292 Add memory format support to theresize_op.operator==of TensorOptions as confusing one #28076 Killoperator==of TensorOptions as confusing oneresize_as_operator #27979 Add memory format support toresize_as_operatorDifferential Revision: D18044977