Fix clang-tidy errors in csrc/Module.cpp #28283
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Oct 18, 2019
Differential Revision: [D18007434](https://our.internmc.facebook.com/intern/diff/D18007434) [ghstack-poisoned]
Differential Revision: [D18007434](https://our.internmc.facebook.com/intern/diff/D18007434) [ghstack-poisoned]
Collaborator
Author
|
@pytorchbot retest this please |
ezyang
approved these changes
Oct 21, 2019
albanD
added a commit
to albanD/pytorch
that referenced
this pull request
Oct 21, 2019
ghstack-source-id: 5971013 Pull Request resolved: pytorch#28283
Differential Revision: [D18007434](https://our.internmc.facebook.com/intern/diff/D18007434) [ghstack-poisoned]
albanD
pushed a commit
to albanD/pytorch
that referenced
this pull request
Oct 30, 2019
ghstack-source-id: 15bb3ff Pull Request resolved: pytorch#28283
Differential Revision: [D18249632](https://our.internmc.facebook.com/intern/diff/D18249632) [ghstack-poisoned]
albanD
added a commit
to albanD/pytorch
that referenced
this pull request
Nov 1, 2019
ghstack-source-id: 7cf8bf5 Pull Request resolved: pytorch#28283
Differential Revision: [D18249632](https://our.internmc.facebook.com/intern/diff/D18249632) [ghstack-poisoned]
albanD
added a commit
to albanD/pytorch
that referenced
this pull request
Nov 4, 2019
ghstack-source-id: c7aaa10 Pull Request resolved: pytorch#28283
Differential Revision: [D18249632](https://our.internmc.facebook.com/intern/diff/D18249632) [ghstack-poisoned]
albanD
added a commit
to albanD/pytorch
that referenced
this pull request
Nov 4, 2019
ghstack-source-id: ebe6a8f Pull Request resolved: pytorch#28283
Differential Revision: [D18249632](https://our.internmc.facebook.com/intern/diff/D18249632) [ghstack-poisoned]
albanD
added a commit
to albanD/pytorch
that referenced
this pull request
Nov 5, 2019
ghstack-source-id: dc3757e Pull Request resolved: pytorch#28283
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 7, 2019
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D18249632