Change error message for torch.linspace(). #28274
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezyang
requested changes
Oct 18, 2019
Contributor
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
I don't think this is right. the _out variant may be called directly if you say torch.linspace(..., out=...). Tests would demonstrate this
Contributor
Author
|
Ah my bad. So the correct way would be not delete the lines in the |
Contributor
Author
|
Fixed. |
ezyang
approved these changes
Oct 20, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 21, 2019
Summary: Fix for pytorch/pytorch#25810 Basically moves the error checking from the device-specific function to the native function. Pull Request resolved: pytorch/pytorch#28274 Differential Revision: D18032189 Pulled By: ezyang fbshipit-source-id: 9072b5980aa2057274e79bc7241db853bfc36f11
Contributor
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: Fix for pytorch#25810 Basically moves the error checking from the device-specific function to the native function. Pull Request resolved: pytorch#28274 Differential Revision: D18032189 Pulled By: ezyang fbshipit-source-id: 9072b5980aa2057274e79bc7241db853bfc36f11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #25810
Basically moves the error checking from the device-specific function to the native function.