Remove confusing torch::jit::RegisterOperators for custom ops #28229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have `torch::RegisterOperators` for custom ops. `torch::jit::RegisterOperators` had a dual state of being able to register custom ops if called one way and being able to register pure JIT ops if called another way. This is confusing because you end up in different operator libraries depending on which API exactly you're using. This PR removes the ability for torch::jit::RegisterOperators to register custom ops and forces people to use the new torch::RegisterOperators. This was already deprecated before but we now remove it. Differential Revision: [D17981895](https://our.internmc.facebook.com/intern/diff/D17981895/) [ghstack-poisoned]
facebook-github-bot
added
the
oncall: jit
smessmer
added a commit
that referenced
this pull request
Oct 17, 2019
We have `torch::RegisterOperators` for custom ops. `torch::jit::RegisterOperators` had a dual state of being able to register custom ops if called one way and being able to register pure JIT ops if called another way. This is confusing because you end up in different operator libraries depending on which API exactly you're using. This PR removes the ability for torch::jit::RegisterOperators to register custom ops and forces people to use the new torch::RegisterOperators. This was already deprecated before but we now remove it. Differential Revision: [D17981895](https://our.internmc.facebook.com/intern/diff/D17981895/) ghstack-source-id: 92106839 Pull Request resolved: #28229
bddppq
reviewed
Oct 17, 2019
Contributor
bddppq
left a comment
bddppq
left a comment
There was a problem hiding this comment.
There are a few places still using it:
https://github.com/pytorch/pytorch/blob/319ef3b/test/onnx/test_custom_ops.py#L22-L23
https://github.com/pytorch/pytorch/blob/319ef3b/test/test_cpp_extensions.py#L580
https://github.com/pytorch/glow/blob/1656b9a/torch_glow/src/PyTorchCommon.cpp#L54
https://github.com/pytorch/glow/blob/1656b9a/torch_glow/src/PyTorchCommon.cpp#L156
https://github.com/pytorch/glow/blob/1656b9a/torch_glow/src/PyTorchFileLoader.cpp#L106
…ops" We have `torch::RegisterOperators` for custom ops. `torch::jit::RegisterOperators` had a dual state of being able to register custom ops if called one way and being able to register pure JIT ops if called another way. This is confusing because you end up in different operator libraries depending on which API exactly you're using. This PR removes the ability for torch::jit::RegisterOperators to register custom ops and forces people to use the new torch::RegisterOperators. This was already deprecated before but we now remove it. Differential Revision: [D17981895](https://our.internmc.facebook.com/intern/diff/D17981895/) [ghstack-poisoned]
…ops" We have `torch::RegisterOperators` for custom ops. `torch::jit::RegisterOperators` had a dual state of being able to register custom ops if called one way and being able to register pure JIT ops if called another way. This is confusing because you end up in different operator libraries depending on which API exactly you're using. This PR removes the ability for torch::jit::RegisterOperators to register custom ops and forces people to use the new torch::RegisterOperators. This was already deprecated before but we now remove it. Differential Revision: [D17981895](https://our.internmc.facebook.com/intern/diff/D17981895/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Oct 17, 2019
Pull Request resolved: #28229 We have `torch::RegisterOperators` for custom ops. `torch::jit::RegisterOperators` had a dual state of being able to register custom ops if called one way and being able to register pure JIT ops if called another way. This is confusing because you end up in different operator libraries depending on which API exactly you're using. This PR removes the ability for torch::jit::RegisterOperators to register custom ops and forces people to use the new torch::RegisterOperators. This was already deprecated before but we now remove it. ghstack-source-id: 92137305 Differential Revision: [D17981895](https://our.internmc.facebook.com/intern/diff/D17981895/)
zdevito
approved these changes
Oct 18, 2019
Contributor
|
This pull request has been merged in 2432986. |
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
…h#28229) Summary: Pull Request resolved: pytorch#28229 We have `torch::RegisterOperators` for custom ops. `torch::jit::RegisterOperators` had a dual state of being able to register custom ops if called one way and being able to register pure JIT ops if called another way. This is confusing because you end up in different operator libraries depending on which API exactly you're using. This PR removes the ability for torch::jit::RegisterOperators to register custom ops and forces people to use the new torch::RegisterOperators. This was already deprecated before but we now remove it. ghstack-source-id: 92137305 Test Plan: unit tests Differential Revision: D17981895 fbshipit-source-id: 0af267dfdc3c6a2736740091cf841bac40deff40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
We have
torch::RegisterOperatorsfor custom ops.torch::jit::RegisterOperatorshad a dual state of being able to register custom ops if called one way and being able to register pure JIT ops if called another way.This is confusing because you end up in different operator libraries depending on which API exactly you're using.
This PR removes the ability for torch::jit::RegisterOperators to register custom ops and forces people to use the new torch::RegisterOperators.
This was already deprecated before but we now remove it.
Differential Revision: D17981895