Support Exporting Bitshift to ONNX #28210
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spandantiwari
suggested changes
Oct 17, 2019
spandantiwari
left a comment
spandantiwari
left a comment
There was a problem hiding this comment.
Could you please confirm if onnx::bitshift can be used here or not.
Contributor
Author
|
@pytorchbot rebase this please |
Contributor
|
CI failure is TestONNXRuntime_opset11::test_bitshift_uint8 FAILED |
Contributor
Author
|
thank you @neginraoof, I had forgotten about this one. I updated the ORT version for the test. |
neginraoof
reviewed
Nov 6, 2019
BowenBao
requested changes
Nov 6, 2019
added 4 commits
November 8, 2019 09:32
Contributor
|
Thanks. Looks good. |
Contributor
Author
|
@pytorchbot rebase this please |
spandantiwari
approved these changes
Nov 18, 2019
spandantiwari
left a comment
spandantiwari
left a comment
There was a problem hiding this comment.
LGTM. Please address a single comment that I have.
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
Contributor
|
@houseroad merged this pull request in 45024e7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support exporting left/right bitshifts to ONNX for all opset versions.
ONNX has a bitshift operator in opset 11, but it only supports unsigned ints, so it can't be used in PyTorch (since only uint8 is the only uint type).