Fix avx for c++14 #28207
Closed
Fix avx for c++14 #28207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabling c++14 causes these lines to fail with the error "error: the last argument must be an 8-bit immediate". So let's make them an 8 bit immediate before we enable C++14. Differential Revision: [D17975236](https://our.internmc.facebook.com/intern/diff/D17975236/) [ghstack-poisoned]
Enabling c++14 causes these lines to fail with the error "error: the last argument must be an 8-bit immediate". So let's make them an 8 bit immediate before we enable C++14. Differential Revision: [D17975236](https://our.internmc.facebook.com/intern/diff/D17975236/) [ghstack-poisoned]
Merged
Enabling c++14 causes these lines to fail with the error "error: the last argument must be an 8-bit immediate". So let's make them an 8 bit immediate before we enable C++14. Differential Revision: [D17975236](https://our.internmc.facebook.com/intern/diff/D17975236/) [ghstack-poisoned]
Enabling c++14 causes these lines to fail with the error "error: the last argument must be an 8-bit immediate". So let's make them an 8 bit immediate before we enable C++14. Differential Revision: [D17975236](https://our.internmc.facebook.com/intern/diff/D17975236/) [ghstack-poisoned]
This was referenced Oct 22, 2019
dzhulgakov
approved these changes
Oct 22, 2019
Enabling c++14 causes these lines to fail with the error "error: the last argument must be an 8-bit immediate". So let's make them an 8 bit immediate before we enable C++14. Differential Revision: [D17975236](https://our.internmc.facebook.com/intern/diff/D17975236/) [ghstack-poisoned]
Enabling c++14 causes these lines to fail with the error "error: the last argument must be an 8-bit immediate". So let's make them an 8 bit immediate before we enable C++14. Differential Revision: [D17975236](https://our.internmc.facebook.com/intern/diff/D17975236/) [ghstack-poisoned]
Enabling c++14 causes these lines to fail with the error "error: the last argument must be an 8-bit immediate". So let's make them an 8 bit immediate before we enable C++14. Differential Revision: [D17975236](https://our.internmc.facebook.com/intern/diff/D17975236/) [ghstack-poisoned]
Enabling c++14 causes these lines to fail with the error "error: the last argument must be an 8-bit immediate". So let's make them an 8 bit immediate before we enable C++14. Differential Revision: [D17975236](https://our.internmc.facebook.com/intern/diff/D17975236/) [ghstack-poisoned]
Contributor
|
This pull request has been merged in 0d4009d. |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 23, 2019
Summary: Pull Request resolved: pytorch/pytorch#28207 Enabling c++14 causes these lines to fail with the error "error: the last argument must be an 8-bit immediate". So let's make them an 8 bit immediate before we enable C++14. ghstack-source-id: 92419812 Test Plan: Enabling C++14 before this PR shows the error, after this PR does not. Differential Revision: D17975236 fbshipit-source-id: aa53cdb2d38d89ede2212ed7374fedeb5896f254
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: Pull Request resolved: pytorch#28207 Enabling c++14 causes these lines to fail with the error "error: the last argument must be an 8-bit immediate". So let's make them an 8 bit immediate before we enable C++14. ghstack-source-id: 92419812 Test Plan: Enabling C++14 before this PR shows the error, after this PR does not. Differential Revision: D17975236 fbshipit-source-id: aa53cdb2d38d89ede2212ed7374fedeb5896f254
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Enabling c++14 causes these lines to fail with the error "error: the last argument must be an 8-bit immediate".
So let's make them an 8 bit immediate before we enable C++14.
Differential Revision: D17975236