Fix LayerNorm Bug #28196
Closed
Fix LayerNorm Bug #28196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Fix LayerNorm Bug Test Plan: buck test mode/dev-nosan caffe2/test:nn -- "LayerNorm" Differential Revision: D17973451 fbshipit-source-id: 8d6137bf1275ef578d9adf057b4681a2cb571de9
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D17973451 |
ngimel
approved these changes
Oct 17, 2019
Collaborator
ngimel
left a comment
ngimel
left a comment
There was a problem hiding this comment.
Let's land this, but please add the tests. Also, doing at::empty_like(gamma) with the proper dtype will make code more readable.
Contributor
|
This pull request has been merged in d083b44. |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 17, 2019
Summary: Pull Request resolved: pytorch/pytorch#28196 Fix LayerNorm Bug Test Plan: buck test mode/dev-nosan caffe2/test:nn -- "LayerNorm" Reviewed By: okhonko, houseroad Differential Revision: D17973451 fbshipit-source-id: 865e4f295b8d6c0438ec8872da0b43d3c5d3d3c6
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: Pull Request resolved: pytorch#28196 Fix LayerNorm Bug Test Plan: buck test mode/dev-nosan caffe2/test:nn -- "LayerNorm" Reviewed By: okhonko, houseroad Differential Revision: D17973451 fbshipit-source-id: 865e4f295b8d6c0438ec8872da0b43d3c5d3d3c6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fix LayerNorm Bug
Test Plan: buck test mode/dev-nosan caffe2/test:nn -- "LayerNorm"
Differential Revision: D17973451