torch.nn.functional.gumbel_softmax #27078 #28121
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naresh1318
requested review from
ebetica,
goldsborough and
yf225
as code owners
yf225
reviewed
Oct 16, 2019
Contributor
yf225
left a comment
yf225
left a comment
There was a problem hiding this comment.
@Naresh1318 Thanks so much for the awesome work! I left some minor comments.
yf225
approved these changes
Oct 18, 2019
Contributor
yf225
left a comment
yf225
left a comment
There was a problem hiding this comment.
@Naresh1318 Thanks so much for the awesome work! I will merge it after CI passes :D
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@yf225 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: **Comments:** * Grad check from https://github.com/pytorch/pytorch/blob/848d1ba13a3f77bb6f14656f2d84e2228e37a8ef/test/test_nn.py#L8898 not added * Double data type as seen in https://github.com/pytorch/pytorch/blob/848d1ba13a3f77bb6f14656f2d84e2228e37a8ef/test/test_nn.py#L8916 not tested **Issue:** pytorch#27078 Pull Request resolved: pytorch#28121 Differential Revision: D18008515 Pulled By: yf225 fbshipit-source-id: 9363fe9430df0f2bfd337cc788b11ac93adaa360
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments:
pytorch/test/test_nn.py
Line 8898 in 848d1ba
pytorch/test/test_nn.py
Line 8916 in 848d1ba
Issue:
#27078