-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Kill operator== of TensorOptions as confusing one
#28076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
VitalyFedyunin
wants to merge
23
commits into
gh/VitalyFedyunin/15/base
from
gh/VitalyFedyunin/15/head
Closed
Kill operator== of TensorOptions as confusing one
#28076
VitalyFedyunin
wants to merge
23
commits into
gh/VitalyFedyunin/15/base
from
gh/VitalyFedyunin/15/head
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Oct 16, 2019
…s confusing one" [ghstack-poisoned]
…g one" [ghstack-poisoned]
…g one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]
This was referenced Oct 18, 2019
Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]
…g one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]
…sing one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]
Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]
Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]
…rOptions as confusing one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]
…"Kill `operator==` of TensorOptions as confusing one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]
…confusing one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]
Closed
… TensorOptions as confusing one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]
…one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]
…nfusing one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]
Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]
This was referenced Nov 8, 2019
Closed
…sing one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]
ezyang
approved these changes
Nov 10, 2019
Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]
…s confusing one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]
Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]
…ng one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]
…ng one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]
…ng one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]
Contributor
|
@VitalyFedyunin merged this pull request in 026a2a4. |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Nov 18, 2019
Summary: Pull Request resolved: pytorch/pytorch#28076 Test Plan: Imported from OSS Differential Revision: D17980306 Pulled By: VitalyFedyunin fbshipit-source-id: 2f206d5069ce0bd828d4e96f2e98cf2baa1dfec7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
resize_op. #28292 Add memory format support to theresize_op.operator==of TensorOptions as confusing one #28076 Killoperator==of TensorOptions as confusing oneresize_as_operator #27979 Add memory format support toresize_as_operatorDifferential Revision: D17980306