[quant][graphmode] Make HistogramObserver scriptable with @torch.jit.ignore
#27950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Make observers scriptable with `@torch.jit.ignore` Test Plan: python test/test_quantization.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
… in graph mode" Summary: Make observers scriptable with `@torch.jit.ignore` Test Plan: python test/test_quantization.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
… in graph mode" Summary: Make observers scriptable with `@torch.jit.ignore` Test Plan: python test/test_quantization.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
… in graph mode" Summary: Make observers scriptable with `@torch.jit.ignore` Test Plan: python test/test_quantization.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
… in graph mode" Summary: Make observers scriptable with `@torch.jit.ignore` Test Plan: python test/test_quantization.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
… in graph mode" Summary: Make observers scriptable with `@torch.jit.ignore` Test Plan: python test/test_quantization.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
… in graph mode" Summary: Make observers scriptable with `@torch.jit.ignore` Test Plan: python test/test_quantization.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
… in graph mode" Summary: Make observers scriptable with `@torch.jit.ignore` Test Plan: python test/test_quantization.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
… in graph mode" Summary: Make HistogramObserver scriptable with `@torch.jit.ignore` Test Plan: python test/test_quantization.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
…`@torch.jit.ignore`" Summary: att Test Plan: python test/test_quantization.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
changed the title
@torch.jit.ignore
Contributor
Author
|
This is ready for review please take a look |
ZolotukhinM
approved these changes
Nov 6, 2019
ZolotukhinM
left a comment
ZolotukhinM
left a comment
There was a problem hiding this comment.
Looks good, but please remove unnecessary changes and split out unrelated changes and avoid that in future.
torch/csrc/jit/script/module.cpp
Outdated
| r.register_attribute( | ||
| s.name, | ||
| s.value.type(), | ||
| type()->getAttribute(s.name), |
| def _combine_histograms( | ||
| self, dst_histogram, dst_min, dst_max, src_histogram, src_min, src_max | ||
| ): | ||
| # type: (Tensor, float, float, Tensor, float, float) -> Tensor |
There was a problem hiding this comment.
Do you need this if the function is ignored?
Contributor
Author
There was a problem hiding this comment.
yeah, we need this otherwise everything will be treated as Tensor
| # remaining should go to dst_bin2 | ||
| if dst_bin_cnt < src_bin_count: | ||
| dst_histogram[dst_bin2] += src_bin_count - dst_bin_cnt | ||
| return dst_histogram |
There was a problem hiding this comment.
This seems to be an unnecessary change.
Contributor
Author
There was a problem hiding this comment.
this is needed for compile as well, ignored functions seems to take Tensor as return only
…`@torch.jit.ignore`" Summary: att Test Plan: python test/test_quantization.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
…`@torch.jit.ignore`" Summary: att Test Plan: python test/test_quantization.py Reviewers: pt1quant Subscribers: Tasks: Tags: Differential Revision: [D18360139](https://our.internmc.facebook.com/intern/diff/D18360139) [ghstack-poisoned]
…`@torch.jit.ignore`" Summary: att Test Plan: python test/test_quantization.py Reviewers: pt1quant Subscribers: Tasks: Tags: Differential Revision: [D18360139](https://our.internmc.facebook.com/intern/diff/D18360139) [ghstack-poisoned]
Contributor
|
This pull request has been merged in 4bcf479. |
xxtEchjovs44
pushed a commit
to xxtEchjovs44/pytorch
that referenced
this pull request
Jan 29, 2020
….ignore` Summary: att Test Plan: python test/test_quantization.py Reviewers: pt1quant Subscribers: Tasks: Tags: ghstack-source-id: add7f5d Pull Request resolved: pytorch/pytorch#27950
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
torch.jit.ignore#29416 [quant] Make PerChannelMinMaxObserver scriptable usingtorch.jit.ignore@torch.jit.ignore#27950 [quant][graphmode] Make HistogramObserver scriptable with@torch.jit.ignoreSummary:
att
Test Plan:
python test/test_quantization.py
Reviewers:
pt1quant
Subscribers:
Tasks:
Tags:
Differential Revision: D18360139