Relax set_num_threads restriction in parallel native case #27947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Don't throw exception if the requested size is the same as the currently used one Test Plan: ATEN_THREADING=NATIVE python setup.py develop --cmake Reviewers:liujiakai [ghstack-poisoned]
This was referenced Oct 14, 2019
Closed
ilia-cher
requested review from
VitalyFedyunin and
ljk53
and removed request for
ljk53
Summary: Don't throw exception if the requested size is the same as the currently used one Test Plan: ATEN_THREADING=NATIVE python setup.py develop --cmake Reviewers:liujiakai [ghstack-poisoned]
dskhudia
reviewed
Oct 15, 2019
dskhudia
approved these changes
Oct 15, 2019
Summary: Don't throw exception if the requested size is the same as the currently used one Test Plan: ATEN_THREADING=NATIVE python setup.py develop --cmake Reviewers:liujiakai Differential Revision: [D17919416](https://our.internmc.facebook.com/intern/diff/D17919416) [ghstack-poisoned]
VitalyFedyunin
approved these changes
Oct 16, 2019
added 3 commits
October 16, 2019 12:09
Summary: Don't throw exception if the requested size is the same as the currently used one Test Plan: ATEN_THREADING=NATIVE python setup.py develop --cmake Reviewers:liujiakai Differential Revision: [D17919416](https://our.internmc.facebook.com/intern/diff/D17919416) [ghstack-poisoned]
Summary: Don't throw exception if the requested size is the same as the currently used one Test Plan: ATEN_THREADING=NATIVE python setup.py develop --cmake Reviewers:liujiakai Differential Revision: [D17919416](https://our.internmc.facebook.com/intern/diff/D17919416) [ghstack-poisoned]
Summary: Don't throw exception if the requested size is the same as the currently used one Test Plan: ATEN_THREADING=NATIVE python setup.py develop --cmake Reviewers:liujiakai Differential Revision: [D17919416](https://our.internmc.facebook.com/intern/diff/D17919416) [ghstack-poisoned]
ilia-cher
requested review from
ebetica,
goldsborough and
yf225
as code owners
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 17, 2019
Summary: Pull Request resolved: pytorch/pytorch#27947 Don't throw exception if the requested size is the same as the currently used one Test Plan: ATEN_THREADING=NATIVE python setup.py develop --cmake Imported from OSS Differential Revision: D17919416 fbshipit-source-id: 411f7c9bd6a46e7a003b43a200c2ce3b76453a2e
Contributor
|
This pull request has been merged in 19956b2. |
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
) Summary: Pull Request resolved: pytorch#27947 Don't throw exception if the requested size is the same as the currently used one Test Plan: ATEN_THREADING=NATIVE python setup.py develop --cmake Imported from OSS Differential Revision: D17919416 fbshipit-source-id: 411f7c9bd6a46e7a003b43a200c2ce3b76453a2e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Don't throw exception if the requested size is the same as the currently
used one
Test Plan:
ATEN_THREADING=NATIVE python setup.py develop --cmake
Reviewers:liujiakai
Differential Revision: D17919416