Nicer promotion error message when pr. #27941
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of an abstruse "unsupported scalarType", we print more.
nairbv
approved these changes
Oct 15, 2019
Collaborator
Author
|
@pytorchbot merge this please |
pytorchbot
added
the
merge-this-please
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 16, 2019
Summary: Instead of an abstruse "unsupported scalarType", we print more. Pull Request resolved: pytorch/pytorch#27941 Differential Revision: D17933972 Pulled By: ezyang fbshipit-source-id: 51e0e1c11e530606612482e24ff28898323e54fc
Contributor
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: Instead of an abstruse "unsupported scalarType", we print more. Pull Request resolved: pytorch#27941 Differential Revision: D17933972 Pulled By: ezyang fbshipit-source-id: 51e0e1c11e530606612482e24ff28898323e54fc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of an abstruse "unsupported scalarType", we print more.