Add note that cuda quantization is not supported #27829
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soumith
approved these changes
Oct 14, 2019
docs/source/quantization.rst
Outdated
Contributor
There was a problem hiding this comment.
The corresponding implementation
Contributor
|
We will also update the tutorial documentation to reflect this. |
gottbrath
approved these changes
Oct 14, 2019
Contributor
gottbrath
left a comment
gottbrath
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks!
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@dzhulgakov is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
dzhulgakov
pushed a commit
that referenced
this pull request
Oct 14, 2019
Summary: People get confused with partial support otherwise: #27811 #27729 Suggestions on where else put warnings are welcomed (probably in tutorials - cc SethHWeidman ) Pull Request resolved: #27829 Differential Revision: D17910931 Pulled By: dzhulgakov fbshipit-source-id: 37a169a4bef01b94be59fe62a8f641c3ec5e9b7c
Contributor
|
@dzhulgakov merged this pull request in 169327f. |
soumith
pushed a commit
that referenced
this pull request
Oct 30, 2019
Summary: People get confused with partial support otherwise: #27811 #27729 Suggestions on where else put warnings are welcomed (probably in tutorials - cc SethHWeidman ) Pull Request resolved: #27829 Differential Revision: D17910931 Pulled By: dzhulgakov fbshipit-source-id: 37a169a4bef01b94be59fe62a8f641c3ec5e9b7c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People get confused with partial support otherwise: #27811 #27729
Suggestions on where else put warnings are welcomed (probably in tutorials - cc @SethHWeidman )