Remove unnecessary BUILD_DIR variable in Android CMake build #27663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake sets CMAKE_BINARY_DIR and creates it automatically. Using this allows us to use the -B command-line flag to CMake to specify an alternate output directory.
pytorchbot
added
module: android
This was referenced Oct 9, 2019
IvanKobzarev
approved these changes
Oct 10, 2019
CMake sets CMAKE_BINARY_DIR and creates it automatically. Using this allows us to use the -B command-line flag to CMake to specify an alternate output directory. Differential Revision: [D18210316](https://our.internmc.facebook.com/intern/diff/D18210316)
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
CMake sets CMAKE_BINARY_DIR and creates it automatically. Using this
allows us to use the -B command-line flag to CMake to specify an
alternate output directory.
Differential Revision: D18210316