Add host build for pytorch_android #27662
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new gradle subproject at pytorch_android/host and tweaks the top-level build.gradle to only run some Android bits on the other projects. Referencing Java sources from inside the host directory feels a bit hacky, but getting host and Android Gradle builds to coexist in the same directory hit several roadblocks. We can try a bigger refactor to separate the Android-specific and non-Android-specific parts of the code, but that seems overkill at this point for 4 Java files. This doesn't actually run without some local changes to fbjni, but I want to get the files landed to avoid unnecessary merge conflicts.
This was referenced Oct 9, 2019
IvanKobzarev
approved these changes
Oct 10, 2019
Collaborator
what are the required changes? |
Contributor
Author
|
This adds a new gradle subproject at pytorch_android/host and tweaks the top-level build.gradle to only run some Android bits on the other projects. Referencing Java sources from inside the host directory feels a bit hacky, but getting host and Android Gradle builds to coexist in the same directory hit several roadblocks. We can try a bigger refactor to separate the Android-specific and non-Android-specific parts of the code, but that seems overkill at this point for 4 Java files. This doesn't actually run without some local changes to fbjni, but I want to get the files landed to avoid unnecessary merge conflicts. Differential Revision: [D18210317](https://our.internmc.facebook.com/intern/diff/D18210317)
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This adds a new gradle subproject at pytorch_android/host and tweaks
the top-level build.gradle to only run some Android bits on the other
projects.
Referencing Java sources from inside the host directory feels a bit
hacky, but getting host and Android Gradle builds to coexist in the same
directory hit several roadblocks. We can try a bigger refactor to
separate the Android-specific and non-Android-specific parts of the
code, but that seems overkill at this point for 4 Java files.
This doesn't actually run without some local changes to fbjni, but I
want to get the files landed to avoid unnecessary merge conflicts.
Differential Revision: D18210317