[C++ API parity] Soft Margin loss #27660
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarMiranda
requested review from
ebetica,
goldsborough and
yf225
as code owners
yf225
reviewed
Oct 11, 2019
Contributor
yf225
left a comment
yf225
left a comment
There was a problem hiding this comment.
Thanks so much for the fantastic work @CarMiranda! I left some comments.
yf225
approved these changes
Oct 15, 2019
Contributor
yf225
left a comment
yf225
left a comment
There was a problem hiding this comment.
@CarMiranda Thanks a lot for the awesome work! I will merge it after CI passes :D
Contributor
|
@pytorchbot rebase this please |
Contributor
|
TODO: wait for #27422 to land first, and then use |
Contributor
|
@pytorchbot rebase this please |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@yf225 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: In accordance with pytorch#25883, I added the `SoftMarginLoss` module and `soft_margin_loss` functional. Pull Request resolved: pytorch#27660 Differential Revision: D17958325 Pulled By: yf225 fbshipit-source-id: c14422765e6e1fdabf6c9687080e6d5ff490d300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In accordance with #25883, I added the
SoftMarginLossmodule andsoft_margin_lossfunctional.