Skip to content

Conversation

@neginraoof
Copy link
Contributor

Opset 11 updates:

  • Enabled ORT tests for updated ops in opset 11
  • Updated index_copy and index_fill symbolic for opset 11 to modify onnx::Scatter -> onnx::ScatterElemets

@pytorchbot pytorchbot added the module: onnx Related to torch.onnx label Oct 8, 2019
@pytorchbot pytorchbot added the module: ci Related to continuous integration label Oct 10, 2019
@neginraoof
Copy link
Contributor Author

@pytorchbot retest this please

@neginraoof
Copy link
Contributor Author

cc @houseroad for review

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Collaborator

@BowenBao BowenBao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neginraoof
Copy link
Contributor Author

cc @houseroad for review

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@houseroad
Copy link
Member

@pytorchbot rebase this please

Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@houseroad merged this pull request in 3d2c901.

thiagocrepaldi pushed a commit to thiagocrepaldi/pytorch that referenced this pull request Feb 4, 2020
Summary:
Opset 11 updates:
- Enabled ORT tests for updated ops in opset 11
- Updated index_copy and index_fill symbolic for opset 11 to modify onnx::Scatter -> onnx::ScatterElemets
Pull Request resolved: pytorch#27578

Reviewed By: hl475

Differential Revision: D17852462

Pulled By: houseroad

fbshipit-source-id: c88747804054d0f3455f2c58fd1d8725e0b2f803
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged module: ci Related to continuous integration module: onnx Related to torch.onnx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants