Skip to content

Fix compilation error when buildng with FFMPEG #27533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
soumith merged 1 commit into from
Oct 8, 2019
Merged

Fix compilation error when buildng with FFMPEG #27533

soumith merged 1 commit into from
Oct 8, 2019

Conversation

@t-kuha
Copy link
Contributor

@t-kuha t-kuha commented Oct 8, 2019

When building with FFMPEG, I encountered compilation error due to missing include/library.
I also find the change in video_input_op.h will improve build on Windows.

@pytorchbot pytorchbot added caffe2 module: build Build system issues labels Oct 8, 2019
@t-kuha t-kuha mentioned this pull request Oct 8, 2019
Closed
@soumith soumith merged commit 93f83dd into pytorch:master Oct 8, 2019
@soumith
Copy link
Contributor

soumith commented Oct 8, 2019

this got reverted. I assumed the PR was for v1.3.0 branch, as it was marked in the release issue #27011 my bad.

@t-kuha t-kuha mentioned this pull request Oct 9, 2019
Closed
@kostmo
Copy link
Member

kostmo commented Oct 9, 2019

this got reverted. I assumed the PR was for v1.3.0 branch, as it was marked in the release issue #27011 my bad.

Thanks for leaving this comment. My Dr. CI tool caches master commits, and this explains why the cache contained a commit (93f83dd) that is no longer in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

caffe2 module: build Build system issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@t-kuha @soumith @kostmo @pytorchbot