Rename PythonUDF{Call,Resp} #27530
Closed
Rename PythonUDF{Call,Resp} #27530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per discussion in #27286, the `UDF` part is superfluous. This makes the naming consistent with the `MessageType` enum.
pytorchbot
added
caffe2
module: build
This was referenced Oct 8, 2019
Per discussion in #27286, the `UDF` part is superfluous. This makes the naming consistent with the `MessageType` enum.
mrshenli
approved these changes
Oct 8, 2019
Contributor
mrshenli
left a comment
mrshenli
left a comment
There was a problem hiding this comment.
Stamp the changes on the names, but tests are broken since the PR before this one. Please fix before landing.
Per discussion in #27286, the `UDF` part is superfluous. This makes the naming consistent with the `MessageType` enum. Differential Revision: [D17808211](https://our.internmc.facebook.com/intern/diff/D17808211)
pietern
added
the
module: rpc
Per discussion in #27286, the `UDF` part is superfluous. This makes the naming consistent with the `MessageType` enum. Differential Revision: [D17808211](https://our.internmc.facebook.com/intern/diff/D17808211)
Per discussion in #27286, the `UDF` part is superfluous. This makes the naming consistent with the `MessageType` enum. Differential Revision: [D17808211](https://our.internmc.facebook.com/intern/diff/D17808211)
Per discussion in #27286, the `UDF` part is superfluous. This makes the naming consistent with the `MessageType` enum. Differential Revision: [D17808211](https://our.internmc.facebook.com/intern/diff/D17808211)
Contributor
Author
|
The commit that's landing has a fix for the build failures in the most recent commit in this PR. |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Per discussion in #27286, the
UDFpart is superfluous.This makes the naming consistent with the
MessageTypeenum.Differential Revision: D17808211