C++ API: torch::nn::Softmax2d #27509
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks a lot for the great work! We will need some fixes as suggested in #27446. |
nuka137
changed the title
Contributor
Author
yf225
reviewed
Oct 11, 2019
| /// about the exact behavior of this module. | ||
| class TORCH_API Softmax2dImpl : public torch::nn::Cloneable<Softmax2dImpl> { | ||
| public: | ||
| Softmax2dImpl(); |
Contributor
There was a problem hiding this comment.
We can remove the default constructor because it will be created by default :D
yf225
reviewed
Oct 11, 2019
|
|
||
| // ============================================================================ | ||
|
|
||
| Softmax2dImpl::Softmax2dImpl() {} |
Contributor
There was a problem hiding this comment.
We can remove the default constructor here :D
Contributor
Author
|
Thanks for reviewing. |
Contributor
|
@pytorchbot rebase this please |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@yf225 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: Add torch::nn::Softmax2d module support for the C++ API. Softmax2d only supports module in Python API, so this PR adds only module support as well. This PR is WIP because it uses the function in pytorch#27446 . After pytorch#27446 is merged, I will remove WIP. Related Issue: pytorch#25883 Reviewer: yf225 Pull Request resolved: pytorch#27509 Differential Revision: D17899715 Pulled By: yf225 fbshipit-source-id: bd891bc995f5a92bf4f5405f8bf07d1bd5de2479
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add torch::nn::Softmax2d module support for the C++ API.
Softmax2d only supports module in Python API, so this PR adds only module support as well.
This PR is WIP because it uses the function in #27446 .
After #27446 is merged, I will remove WIP.
Related Issue: #25883
Reviewer: @yf225