include type promotion info in torch.add/mul/div documentation #27501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
the
module: docs
nairbv
changed the title
nairbv
force-pushed
the
v1.3_add_docfix
branch
from
a5a334e to
bd9d98b
Compare
nairbv
changed the title
gchanan
reviewed
Oct 7, 2019
nairbv
force-pushed
the
v1.3_add_docfix
branch
from
bd9d98b to
38f2da3
Compare
Contributor
|
I'm confused -- does this supercede #25114? |
zou3519
reviewed
Oct 7, 2019
zou3519
reviewed
Oct 7, 2019
torch/_torch_docs.py
Outdated
Contributor
There was a problem hiding this comment.
I want to point out that numpy makes no mention of type promotion in their doc: https://docs.scipy.org/doc/numpy/reference/generated/numpy.add.html
zou3519
reviewed
Oct 7, 2019
zou3519
reviewed
Oct 7, 2019
Collaborator
nairbv
force-pushed
the
v1.3_add_docfix
branch
from
38f2da3 to
d9032db
Compare
Collaborator
Author
|
@pytorchbot retest this please |
gchanan
reviewed
Oct 14, 2019
Contributor
gchanan
left a comment
gchanan
left a comment
There was a problem hiding this comment.
sorry, getting to this late.
| Args: | ||
| {input} | ||
| value (Number): the number to be added to each element of :attr:`input` | ||
| If the :class:`torch.dtype` of :attr:`input` and :attr:`other` differ, |
Contributor
There was a problem hiding this comment.
does this "if" add anything? The the rules of type promotion apply even if the dtypes are the same, right?
| If :attr:`input` is of type `FloatTensor` or `DoubleTensor`, :attr:`other` | ||
| should be a real number, otherwise it should be an integer | ||
| If the :class:`torch.dtype` of :attr:`input` and :attr:`other` differ, |
| If :attr:`input` is of type `FloatTensor` or `DoubleTensor`, :attr:`other` | ||
| should be a real number, otherwise it should be an integer | ||
| If the :class:`torch.dtype` of :attr:`input` and :attr:`other` differ, |
xuhdev
added a commit
to xuhdev/pytorch
that referenced
this pull request
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #25114 but would like to improve torch.add doc on release branch.
Issue: #26825
FYI: @xuhdev