Skip to content

C++ API parity: ReLU #27435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pbelevich wants to merge 11 commits into from
Closed

C++ API parity: ReLU #27435

pbelevich wants to merge 11 commits into from

Conversation

@pbelevich
Copy link
Contributor

@pbelevich pbelevich commented Oct 6, 2019 •
edited
Loading

Stack from ghstack:

Differential Revision: D17835407

@pbelevich
C++ API parity: ReLU
59bece1 
[ghstack-poisoned]
@pytorchbot pytorchbot added the module: cpp Related to C++ API label Oct 6, 2019
This was referenced Oct 6, 2019
Closed
Closed
Closed
Closed
Closed
@yf225 yf225 mentioned this pull request Oct 6, 2019
Open
This was referenced Oct 7, 2019
Closed
Closed
Closed
yf225
yf225 reviewed Oct 8, 2019
View reviewed changes
yf225
yf225 reviewed Oct 8, 2019
View reviewed changes
This was referenced Oct 8, 2019
Closed
Closed
Closed
Closed
Closed
@pbelevich pbelevich requested a review from yf225 October 8, 2019 15:45
@pbelevich pbelevich mentioned this pull request Oct 8, 2019
Closed
yf225
yf225 reviewed Oct 9, 2019
View reviewed changes
@pbelevich
Update on "C++ API parity: ReLU"
07de5a3 
Differential Revision: [D17835407](https://our.internmc.facebook.com/intern/diff/D17835407)

[ghstack-poisoned]
@pbelevich
Update on "C++ API parity: ReLU"
719aec4 
Differential Revision: [D17835407](https://our.internmc.facebook.com/intern/diff/D17835407)

[ghstack-poisoned]
@pbelevich
Update on "C++ API parity: ReLU"
ec61126 
Differential Revision: [D17835407](https://our.internmc.facebook.com/intern/diff/D17835407)

[ghstack-poisoned]
@pbelevich
Update on "C++ API parity: ReLU"
b2908b5 
Differential Revision: [D17835407](https://our.internmc.facebook.com/intern/diff/D17835407)

[ghstack-poisoned]
@pbelevich pbelevich requested a review from yf225 October 10, 2019 17:46
yf225
yf225 approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@yf225 yf225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @pbelevich !

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 10, 2019

@pbelevich merged this pull request in 8515650.

@bddppq
Copy link
Contributor

bddppq commented Oct 10, 2019 •
edited
Loading

Update:

wrong blame, should be 829a5c8

I think this commit is the root cause of the cpp tests failure on current master:
https://circleci.com/api/v1.1/project/github/pytorch/pytorch/3154023/output/105/0?file=true

Oct 10 22:30:06 ======================================================================
Oct 10 22:30:06 ERROR: test_cpp (__main__.TestJit)
Oct 10 22:30:06 ----------------------------------------------------------------------
Oct 10 22:30:06 Traceback (most recent call last):
Oct 10 22:30:06   File "/var/lib/jenkins/workspace/test/common_utils.py", line 206, in wrapper
Oct 10 22:30:06     fn(*args, **kwargs)
Oct 10 22:30:06   File "test_jit.py", line 2049, in test_cpp
Oct 10 22:30:06     torch._C._jit_run_cpp_tests(run_cuda=False)
Oct 10 22:30:06 RuntimeError: basic_string::_M_construct null not valid
Oct 10 22:30:06

@facebook-github-bot facebook-github-bot deleted the gh/pbelevich/34/head branch October 28, 2019 22:17
thiagocrepaldi pushed a commit to thiagocrepaldi/pytorch that referenced this pull request Feb 4, 2020
@pbelevich
C++ API parity: ReLU
9e0257b 
Summary: Pull Request resolved: pytorch#27435

Test Plan: Imported from OSS

Differential Revision: D17835407

Pulled By: pbelevich

fbshipit-source-id: b8ee86c7a76674bc88d8e995424dad22d3caab59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yf225 yf225 yf225 approved these changes

Assignees

No one assigned

Labels

Merged module: cpp Related to C++ API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@pbelevich @facebook-github-bot @bddppq @yf225 @pytorchbot @mruberry