Skip to content

Conversation

@jon-tow
Copy link
Contributor

@jon-tow jon-tow commented Oct 6, 2019

Adds SELU functional and module support for the C++ API.

Issue: #25883

Copy link
Contributor

@pbelevich pbelevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jon-tow !

@jon-tow
Copy link
Contributor Author

jon-tow commented Oct 6, 2019

Thanks for the help @pbelevich, and for laying down a solid foundation to work with. :)

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbelevich has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@yf225 yf225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jon-tow Thanks a lot for the great work! I left a minor comment.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbelevich has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@jon-tow
Copy link
Contributor Author

jon-tow commented Oct 8, 2019

@yf225 Thanks for taking the time to help me out :).

Copy link
Contributor

@yf225 yf225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jon-tow Thanks so much for the great work! :D

@yf225
Copy link
Contributor

yf225 commented Oct 8, 2019

@pytorchbot rebase this please

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yf225 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@jon-tow jon-tow deleted the c++-api/selu-activation branch October 9, 2019 21:50
@facebook-github-bot
Copy link
Contributor

@yf225 merged this pull request in 0fed475.

thiagocrepaldi pushed a commit to thiagocrepaldi/pytorch that referenced this pull request Feb 4, 2020
Summary:
Adds `SELU` functional and module support for the C++ API.

Issue: pytorch#25883
Pull Request resolved: pytorch#27434

Differential Revision: D17782762

Pulled By: yf225

fbshipit-source-id: 96c7ce84b9baf9e219a63e631929b8997ba6f3f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged module: cpp Related to C++ API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants