Skip to content

Conversation

@pbelevich
Copy link
Contributor

@pbelevich pbelevich commented Oct 5, 2019

Stack from ghstack:

Differential Revision: D17835412

[ghstack-poisoned]
Copy link
Contributor

@yf225 yf225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbelevich Thanks a lot for the great work! It looks great overall, and I left some very minor comments.

@facebook-github-bot
Copy link
Contributor

@pbelevich merged this pull request in 1fec144.

@facebook-github-bot facebook-github-bot deleted the gh/pbelevich/33/head branch October 28, 2019 22:17
thiagocrepaldi pushed a commit to thiagocrepaldi/pytorch that referenced this pull request Feb 4, 2020
Summary: Pull Request resolved: pytorch#27429

Test Plan: Imported from OSS

Differential Revision: D17835412

Pulled By: pbelevich

fbshipit-source-id: e678d5920dad1293bb0ba3de28e2da3087d19bde
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged module: cpp Related to C++ API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants