Skip to content

[BC-breaking] C++ API parity: Linear #27382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pbelevich wants to merge 41 commits into from
Closed

[BC-breaking] C++ API parity: Linear #27382

pbelevich wants to merge 41 commits into from

Conversation

@pbelevich
Copy link
Contributor

@pbelevich pbelevich commented Oct 4, 2019 •
edited by yf225
Loading

Stack from ghstack:

This PR is BC-breaking in the following way:

The arguments in LinearOptions are renamed to match the Python API:

  • in -> in_features
  • out -> out_features
  • with_bias -> bias

The accessor calls (e.g. in()) in the user's code needs to be changed accordingly.

Differential Revision: D17766735

@pbelevich
C++ API parity: Linear
f996aa4 
[ghstack-poisoned]
@pytorchbot pytorchbot added the module: cpp Related to C++ API label Oct 4, 2019
This was referenced Oct 4, 2019
Closed
Closed
Closed
Closed
@pbelevich
Update on "C++ API parity: Linear"
ec18c1a 
Differential Revision: [D17766735](https://our.internmc.facebook.com/intern/diff/D17766735)

[ghstack-poisoned]
@pbelevich
Update on "C++ API parity: Linear"
2feada8 
Differential Revision: [D17766735](https://our.internmc.facebook.com/intern/diff/D17766735)

[ghstack-poisoned]
@pbelevich
Update on "C++ API parity: Linear"
8ab4074 
Differential Revision: [D17766735](https://our.internmc.facebook.com/intern/diff/D17766735)

[ghstack-poisoned]
@pbelevich
Update on "C++ API parity: Linear"
1c3c46b 
Differential Revision: [D17766735](https://our.internmc.facebook.com/intern/diff/D17766735)

[ghstack-poisoned]
@pbelevich pbelevich mentioned this pull request Oct 5, 2019
Closed
This was referenced Oct 6, 2019
Closed
Closed
Closed
@yf225 yf225 mentioned this pull request Oct 6, 2019
Open
This was referenced Oct 7, 2019
Closed
Closed
Closed
@pbelevich pbelevich mentioned this pull request Oct 8, 2019
Closed
@pbelevich
Update on "C++ API parity: Linear"
1ea77da 
Differential Revision: [D17766735](https://our.internmc.facebook.com/intern/diff/D17766735)

[ghstack-poisoned]
@pbelevich
Update on "C++ API parity: Linear"
ec0bf39 
Differential Revision: [D17766735](https://our.internmc.facebook.com/intern/diff/D17766735)

[ghstack-poisoned]
@pbelevich
Update on "C++ API parity: Linear"
6e60d7c 
Differential Revision: [D17766735](https://our.internmc.facebook.com/intern/diff/D17766735)

[ghstack-poisoned]
@pbelevich
Update on "C++ API parity: Linear"
c0ec81b 
Differential Revision: [D17766735](https://our.internmc.facebook.com/intern/diff/D17766735)

[ghstack-poisoned]
@pbelevich
Update on "C++ API parity: Linear"
30d25b7 
Differential Revision: [D17766735](https://our.internmc.facebook.com/intern/diff/D17766735)

[ghstack-poisoned]
@pbelevich pbelevich requested a review from yf225 October 12, 2019 01:32
@pbelevich
Update on "C++ API parity: Linear"
b8fb6df 
Differential Revision: [D17766735](https://our.internmc.facebook.com/intern/diff/D17766735)

[ghstack-poisoned]
@pbelevich
Update on "C++ API parity: Linear"
c904050 
Differential Revision: [D17766735](https://our.internmc.facebook.com/intern/diff/D17766735)

[ghstack-poisoned]
@pbelevich
Update on "C++ API parity: Linear"
dbd434b 
Differential Revision: [D17766735](https://our.internmc.facebook.com/intern/diff/D17766735)

[ghstack-poisoned]
@pbelevich
Update on "C++ API parity: Linear"
7c73f09 
Differential Revision: [D17766735](https://our.internmc.facebook.com/intern/diff/D17766735)

[ghstack-poisoned]
yf225
yf225 reviewed Oct 14, 2019
View reviewed changes
Copy link
Contributor

@yf225 yf225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @pbelevich! I left some minor comments.

yf225
yf225 reviewed Oct 16, 2019
View reviewed changes
@pbelevich pbelevich requested a review from yf225 October 19, 2019 19:34
yf225
yf225 approved these changes Oct 20, 2019
View reviewed changes
Copy link
Contributor

@yf225 yf225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbelevich Thanks a lot for the awesome work! We can land it after the fixing the annoying clang-tidy issue :D

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 24, 2019

@pbelevich merged this pull request in dd277e9.

@yf225 yf225 added the module: bc-breaking Related to a BC-breaking change label Oct 25, 2019
@yf225 yf225 changed the title C++ API parity: Linear [BC-breaking] C++ API parity: Linear Oct 25, 2019
@yf225 yf225 mentioned this pull request Oct 28, 2019
Closed
facebook-github-bot pushed a commit that referenced this pull request Oct 28, 2019
@facebook-github-bot
Update C++ parity table for torch::nn::Linear (#28804)
f63cf96 
Summary:
Since we have merged #27382 (thanks pbelevich!)
Pull Request resolved: #28804

Differential Revision: D18185714

Pulled By: yf225

fbshipit-source-id: 1148f5837fbf578843b989fc53fd334519943cdd
@facebook-github-bot facebook-github-bot deleted the gh/pbelevich/32/head branch October 28, 2019 22:17
thiagocrepaldi pushed a commit to thiagocrepaldi/pytorch that referenced this pull request Feb 4, 2020
@pbelevich
C++ API parity: Linear
8a6ff16 
Summary: Pull Request resolved: pytorch#27382

Test Plan: Imported from OSS

Differential Revision: D17766735

Pulled By: pbelevich

fbshipit-source-id: c7a66daeb17550eb9a5d26944427723d4ebdc6c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yf225 yf225 yf225 approved these changes

Assignees

No one assigned

Labels

Merged module: bc-breaking Related to a BC-breaking change module: cpp Related to C++ API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pbelevich @facebook-github-bot @yf225 @pytorchbot @mruberry