[quant][graphmode][fix] insert_prepack_unpack for conv #27346
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: att Test Plan: test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Oct 3, 2019
Summary: att Test Plan: test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: att Test Plan: test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: att Test Plan: test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: att Test Plan: test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: att Test Plan: test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: att Test Plan: test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
ZolotukhinM
approved these changes
Oct 5, 2019
ZolotukhinM
left a comment
ZolotukhinM
left a comment
There was a problem hiding this comment.
How did we miss it in the first place?
Contributor
Author
|
the test just checks we inserted prepack/unpack, it didn't check the arguments of aten::conv |
Summary: att Test Plan: test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: att Test Plan: test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: att Test Plan: test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: att Test Plan: test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: att Test Plan: test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: att Test Plan: test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: att Test Plan: test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: att Test Plan: test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: att Test Plan: test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: att Test Plan: test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: att Test Plan: test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: att Test Plan: test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: att Test Plan: test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: att Test Plan: test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: att Test Plan: test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: att Test Plan: test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: Differential Revision: [D18182915](https://our.internmc.facebook.com/intern/diff/D18182915) [ghstack-poisoned]
Summary: att Test Plan: test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: Differential Revision: [D18182915](https://our.internmc.facebook.com/intern/diff/D18182915) [ghstack-poisoned]
Summary: att Test Plan: test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: Differential Revision: [D18182915](https://our.internmc.facebook.com/intern/diff/D18182915) [ghstack-poisoned]
Summary: att Test Plan: test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: Differential Revision: [D18182915](https://our.internmc.facebook.com/intern/diff/D18182915) [ghstack-poisoned]
Contributor
|
This pull request has been merged in eb00af3. |
1 similar comment
Contributor
|
This pull request has been merged in eb00af3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
att
Test Plan:
test_jit.py
Reviewers:
mvz
Subscribers:
Tasks:
Tags:
Differential Revision: D18182915