Skip to content

Move internal functions to torch.distributed.rpc #27289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pietern wants to merge 5 commits into from
Closed

Move internal functions to torch.distributed.rpc #27289

pietern wants to merge 5 commits into from

Conversation

@pietern
Copy link
Contributor

@pietern pietern commented Oct 3, 2019 •
edited
Loading

Stack from ghstack:

Differential Revision: D17808214

@pytorchbot pytorchbot added oncall: distributed Add this issue/PR to distributed oncall triage queue module: pybind Related to our Python bindings / interactions with other Python libraries labels Oct 3, 2019
This was referenced Oct 3, 2019
Closed
Closed
Closed
Closed
Closed
@pietern pietern mentioned this pull request Oct 3, 2019
Closed
@mrshenli
Copy link
Contributor

mrshenli commented Oct 4, 2019

Test failure is related:

Oct 03 15:01:47 ==================================== ERRORS ====================================
Oct 03 15:01:47 _ ERROR collecting .local/lib/python3.6/site-packages/caffe2/python/workspace_test.py _
Oct 03 15:01:47 ../.local/lib/python3.6/site-packages/caffe2/python/workspace_test.py:12: in <module>
Oct 03 15:01:47     import torch
Oct 03 15:01:47 ../.local/lib/python3.6/site-packages/torch/__init__.py:280: in <module>
Oct 03 15:01:47     from .functional import *
Oct 03 15:01:47 ../.local/lib/python3.6/site-packages/torch/functional.py:2: in <module>
Oct 03 15:01:47     import torch.nn.functional as F
Oct 03 15:01:47 ../.local/lib/python3.6/site-packages/torch/nn/__init__.py:3: in <module>
Oct 03 15:01:47     from .parallel import DataParallel  # noqa: F401
Oct 03 15:01:47 ../.local/lib/python3.6/site-packages/torch/nn/parallel/__init__.py:5: in <module>
Oct 03 15:01:47     from .distributed import DistributedDataParallel
Oct 03 15:01:47 ../.local/lib/python3.6/site-packages/torch/nn/parallel/distributed.py:8: in <module>
Oct 03 15:01:47     import torch.distributed as dist
Oct 03 15:01:47 ../.local/lib/python3.6/site-packages/torch/distributed/__init__.py:23: in <module>
Oct 03 15:01:47     from .rpc_api import _init_rpc
Oct 03 15:01:47 ../.local/lib/python3.6/site-packages/torch/distributed/rpc_api.py:5: in <module>
Oct 03 15:01:47     import torch.distributed.rpc as rpc
Oct 03 15:01:47 E   AttributeError: module 'torch' has no attribute 'distributed'

This was referenced Oct 7, 2019
Closed
Closed
Closed
This was referenced Oct 8, 2019
Closed
Closed
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 8, 2019

@pietern merged this pull request in a6d26ce.

@facebook-github-bot facebook-github-bot deleted the gh/pietern/44/head branch October 28, 2019 22:18
thiagocrepaldi pushed a commit to thiagocrepaldi/pytorch that referenced this pull request Feb 4, 2020
@pietern
Move internal functions to torch.distributed.rpc
6d03870 
Summary: Pull Request resolved: pytorch#27289

Test Plan: Imported from OSS

Differential Revision: D17808214

Pulled By: pietern

fbshipit-source-id: 4c453028e431c3e951d439784017ef07037ba1a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xush6528 xush6528 xush6528 approved these changes

@mrshenli mrshenli mrshenli approved these changes

@apaszke apaszke Awaiting requested review from apaszke

Assignees

No one assigned

Labels

Merged module: pybind Related to our Python bindings / interactions with other Python libraries oncall: distributed Add this issue/PR to distributed oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@pietern @mrshenli @facebook-github-bot @xush6528 @pytorchbot @mruberry