Fix pybind11 warnings in python_rpc_handler.cpp #27284
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warnings related to usage of the deprecated != operator. Instead of checking the member field on every function call, we can check it once, on construction of PythonRpcHandler.
pytorchbot
added
oncall: distributed
This was referenced Oct 3, 2019
xush6528
approved these changes
Oct 3, 2019
Contributor
|
thanks for fixing it! |
Contributor
Author
The warnings related to usage of the deprecated != operator. Instead of checking the member field on every function call, we can check it once, on construction of PythonRpcHandler.
This was referenced Oct 7, 2019
Contributor
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: Pull Request resolved: pytorch#27284 The warnings related to usage of the deprecated != operator. Instead of checking the member field on every function call, we can check it once, on construction of PythonRpcHandler. Test Plan: Imported from OSS Differential Revision: D17808213 Pulled By: pietern fbshipit-source-id: 022c8f77f266942c49c55b1729e62dbb06262d77
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
The warnings related to usage of the deprecated != operator. Instead
of checking the member field on every function call, we can check it
once, on construction of PythonRpcHandler.
Differential Revision: D17808213