[refactor] Remove test_quantizer.py and reuse one of its test in test_quantization.py
#27269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: att Also enable the tests Test Plan: python test/test_quantization.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Oct 3, 2019
…ation.py" Summary: att Also enable the tests Test Plan: python test/test_quantization.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
…ation.py" Summary: att Also enable the tests Test Plan: python test/test_quantization.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
…ation.py" Summary: att Also enable the tests Test Plan: python test/test_quantization.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Oct 3, 2019
…ation.py" Summary: att Also enable the tests Test Plan: python test/test_quantization.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
…ation.py" Summary: att Also enable the tests Test Plan: python test/test_quantization.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
…ation.py" Summary: att Also enable the tests Test Plan: python test/test_quantization.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
…ation.py" Summary: att Also enable the tests Test Plan: python test/test_quantization.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
…ation.py" Summary: att Also enable the tests Test Plan: python test/test_quantization.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
…ation.py" Summary: att Also enable the tests Test Plan: python test/test_quantization.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
|
The added test looks differently from the two tests that were removed. Could you please explain in more details why this is equivalent (also, please add that to the commit message since right now it doesn't look like the test was moved)? |
Contributor
Author
|
for test_quantizer.py, the first test is removed, the second one is the one we move to test_quantization, and I also modified a bit to make it pass |
…ation.py" Summary: att Also enable the tests Test Plan: python test/test_quantization.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
…ation.py" Summary: att Also enable the tests Test Plan: python test/test_quantization.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
…ation.py" Summary: att Also enable the tests Test Plan: python test/test_quantization.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
…ation.py" Summary: att Also enable the tests Test Plan: python test/test_quantization.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
…ation.py" Summary: att Also enable the tests Test Plan: python test/test_quantization.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
…ation.py" Summary: att Also enable the tests Test Plan: python test/test_quantization.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
…ation.py" Summary: att Also enable the tests Test Plan: python test/test_quantization.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
…ation.py" Summary: att Also enable the tests Test Plan: python test/test_quantization.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
…ation.py" Summary: att Also enable the tests Test Plan: python test/test_quantization.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
…ation.py" Summary: att Also enable the tests Test Plan: python test/test_quantization.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
…ation.py" Summary: att Also enable the tests Test Plan: python test/test_quantization.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
…ation.py" Summary: att Also enable the tests Test Plan: python test/test_quantization.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
…ation.py" Summary: att Also enable the tests Test Plan: python test/test_quantization.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
ZolotukhinM
suggested changes
Oct 25, 2019
| result_eager = model_eager(self.calib_data[0][0]) | ||
| torch._C._jit_pass_quant_fusion(model_script._c._get_module('fc1')._get_method('forward').graph) | ||
| result_script = model_script._c._get_method('forward')(self.calib_data[0][0]) | ||
| result_script = get_forward(model_script._c)(self.calib_data[0][0]) |
There was a problem hiding this comment.
Why did this change if that was just a move of the test?
Contributor
Author
There was a problem hiding this comment.
this is move + some modifications to make it pass I'll modify the message
| self.assertEqual(result_eager, result_script) | ||
|
|
||
| @unittest.skip("quantization for inlined linear is not working right now") | ||
| def test_nested(self): |
There was a problem hiding this comment.
It seems that we had more tests before the move, could you please explain why they were changed?
Contributor
Author
There was a problem hiding this comment.
the conv+bn test is added later after we fix the conv patterns
…ation.py" Summary: att Also enable the tests Test Plan: python test/test_quantization.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
changed the title
test_quantizer.py and reuse one of its test in test_quantization.py
… test in `test_quantization.py`" Summary: Remove `test_quantizer.py`, add and rewrite one of the tests in `test_quantizer` in `test_quantization.py` The conv test is removed for now since conv pattern is still broken, we'll add another test later Test Plan: python test/test_quantization.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
… test in `test_quantization.py`" Summary: Remove `test_quantizer.py`, add and rewrite one of the tests in `test_quantizer` in `test_quantization.py` The conv test is removed for now since conv pattern is still broken, we'll add another test later Test Plan: python test/test_quantization.py Reviewers: mvz Subscribers: Tasks: Tags: Differential Revision: [D18182916](https://our.internmc.facebook.com/intern/diff/D18182916) [ghstack-poisoned]
ZolotukhinM
approved these changes
Oct 29, 2019
ZolotukhinM
left a comment
ZolotukhinM
left a comment
There was a problem hiding this comment.
Looks good! In future when you move stuff around please try to split it from non-mechanical changes for easier reviews.
… test in `test_quantization.py`" Summary: Remove `test_quantizer.py`, add and rewrite one of the tests in `test_quantizer` in `test_quantization.py` The conv test is removed for now since conv pattern is still broken, we'll add another test later Test Plan: python test/test_quantization.py Reviewers: mvz Subscribers: Tasks: Tags: Differential Revision: [D18182916](https://our.internmc.facebook.com/intern/diff/D18182916) [ghstack-poisoned]
… test in `test_quantization.py`" Summary: Remove `test_quantizer.py`, add and rewrite one of the tests in `test_quantizer` in `test_quantization.py` The conv test is removed for now since conv pattern is still broken, we'll add another test later Test Plan: python test/test_quantization.py Reviewers: mvz Subscribers: Tasks: Tags: Differential Revision: [D18182916](https://our.internmc.facebook.com/intern/diff/D18182916) [ghstack-poisoned]
… test in `test_quantization.py`" Summary: Remove `test_quantizer.py`, add and rewrite one of the tests in `test_quantizer` in `test_quantization.py` The conv test is removed for now since conv pattern is still broken, we'll add another test later Test Plan: python test/test_quantization.py Reviewers: mvz Subscribers: Tasks: Tags: Differential Revision: [D18182916](https://our.internmc.facebook.com/intern/diff/D18182916) [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Oct 29, 2019
…est_quantization.py` Pull Request resolved: #27269 Remove `test_quantizer.py`, add and rewrite one of the tests in `test_quantizer` in `test_quantization.py` The conv test is removed for now since conv pattern is still broken, we'll add another test later Differential Revision: [D18182916](https://our.internmc.facebook.com/intern/diff/D18182916/) ghstack-source-id: 92869823
Contributor
|
This pull request has been merged in 1c436de. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
test_quantizer.pyand reuse one of its test intest_quantization.py#27269 [refactor] Removetest_quantizer.pyand reuse one of its test intest_quantization.pySummary:
Remove
test_quantizer.py, add and rewrite one of the tests intest_quantizerin
test_quantization.pyThe conv test is removed for now since conv pattern is still broken, we'll add another test
later
Test Plan:
python test/test_quantization.py
Reviewers:
mvz
Subscribers:
Tasks:
Tags:
Differential Revision: D18182916