[ONNX] Export traced aten::unbind #27247
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
oncall: jit
Collaborator
Author
|
cc @lara-hdr @neginraoof @spandantiwari for review |
Contributor
|
Don't we need operator tests for expected model? |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Member
|
I think end to end test is good enough for this case. |
Member
|
@pytorchbot rebase this please |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@houseroad merged this pull request in ba79233. |
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary:
This PR enables exporting aten::unbind created by the tracer. The traced version IR will always have this pattern ```aten::unbind -> prim::ListUnpack```.
Another PR supporting scripted aten::unbind will be submitted separately later.
```
// Unbind is being converted to ONNX as Split + Squeeze.
// Example IR
// graph(%0 : Float(3, 4, 5)):
// %7 : Long() = prim::Constant[value={0}]()
// %3 : Tensor[] = aten::unbind(%0, %7)
// %4 : Float(4, 5), %5 : Float(4, 5), %6 : Float(4, 5) = prim::ListUnpack(%3)
// return (%4, %5, %6)
//
// Translates to ONNX:
// graph(%0 : Float(3, 4, 5)):
// %1 : Tensor, %2 : Tensor, %3 : Tensor = onnx::Split[axis=0](%0)
// %4 : Float(4, 5) = onnx::Squeeze[axes=[0]](%3)
// %5 : Float(4, 5) = onnx::Squeeze[axes=[0]](%2)
// %6 : Float(4, 5) = onnx::Squeeze[axes=[0]](%1)
// return (%6, %5, %4)
```
Pull Request resolved: pytorch#27247
Reviewed By: hl475
Differential Revision: D17791095
Pulled By: houseroad
fbshipit-source-id: 83b724275124dd1dedb272583a2fefbdf7035d4c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables exporting aten::unbind created by the tracer. The traced version IR will always have this pattern
aten::unbind -> prim::ListUnpack.Another PR supporting scripted aten::unbind will be submitted separately later.