[quant][graphmode][fix] Make inserted child module names unique #27237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Making inserted observer module and wrapper module names unique Test Plan: test_jit.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Oct 2, 2019
This was referenced Oct 2, 2019
…nique" Summary: Making inserted observer module and wrapper module names unique Test Plan: test_jit.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
…nique" Summary: Making inserted observer module and wrapper module names unique Test Plan: test_jit.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
…nique" Summary: Making inserted observer module and wrapper module names unique Test Plan: test_jit.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
…nique" Summary: Making inserted observer module and wrapper module names unique Test Plan: test_jit.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Oct 3, 2019
…nique" Summary: Making inserted observer module and wrapper module names unique Test Plan: test_jit.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
…nique" Summary: Making inserted observer module and wrapper module names unique Test Plan: test_jit.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
…nique" Summary: Making inserted observer module and wrapper module names unique Test Plan: test_jit.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
…nique" Summary: Making inserted observer module and wrapper module names unique Test Plan: test_jit.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
ZolotukhinM
suggested changes
Oct 4, 2019
…nique" Summary: Making inserted observer module and wrapper module names unique Test Plan: test_jit.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
…nique" Summary: Making inserted observer module and wrapper module names unique Test Plan: test_jit.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
…nique" Summary: Making inserted observer module and wrapper module names unique Test Plan: test_jit.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
…nique" Summary: Making inserted observer module and wrapper module names unique Test Plan: test_jit.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
…nique" Summary: Making inserted observer module and wrapper module names unique Test Plan: test_jit.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
…nique" Summary: Making inserted observer module and wrapper module names unique Test Plan: test_jit.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
…nique" Summary: Making inserted observer module and wrapper module names unique Test Plan: test_jit.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
…nique" Summary: Making inserted observer module and wrapper module names unique Test Plan: test_jit.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
…nique" Summary: Making inserted observer module and wrapper module names unique Test Plan: test_jit.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
…nique" Summary: Making inserted observer module and wrapper module names unique Test Plan: test_jit.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
…nique" Summary: Making inserted observer module and wrapper module names unique Test Plan: test_jit.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
…nique" Summary: Making inserted observer module and wrapper module names unique Test Plan: test_jit.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
…nique" Summary: Making inserted observer module and wrapper module names unique Test Plan: test_jit.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
…nique" Summary: Making inserted observer module and wrapper module names unique Test Plan: test_jit.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
ZolotukhinM
reviewed
Oct 25, 2019
…nique" Summary: Making inserted observer module and wrapper module names unique Test Plan: test_jit.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
…nique" Summary: Making inserted observer module and wrapper module names unique Test Plan: test_jit.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
…nique" Summary: Making inserted observer module and wrapper module names unique Test Plan: test_jit.py Reviewers: pt1quant Subscribers: Tasks: Tags: Differential Revision: [D18182917](https://our.internmc.facebook.com/intern/diff/D18182917) [ghstack-poisoned]
Contributor
|
This pull request has been merged in 6b5bfd4. |
Contributor
|
This pull request has been merged in 6b5bfd4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
test_quantizer.pyand reuse one of its test intest_quantization.py#27269 [refactor] Removetest_quantizer.pyand reuse one of its test intest_quantization.pySummary:
Making inserted observer module and wrapper module names unique
Test Plan:
test_jit.py
Reviewers:
pt1quant
Subscribers:
Tasks:
Tags:
Differential Revision: D18182917