Handle warning in torchscript #27154
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
Fix for #25859 Differential Revision: [D17692504](https://our.internmc.facebook.com/intern/diff/D17692504) [ghstack-poisoned]
ezyang
reviewed
Oct 2, 2019
| tracer::getTracingState()->graph->pop_scope(); | ||
| } | ||
| return result; | ||
| END_HANDLE_TH_ERRORS_PYBIND |
Contributor
There was a problem hiding this comment.
Why not the other bindings too?
Collaborator
Author
There was a problem hiding this comment.
Because this is the only place where arbitrary pytorch code can actually run (like functions from aten). Other entry points, to the best of my knowledge only work with jit code.
Contributor
There was a problem hiding this comment.
But if those functions ever call TORCH_WARN you still need to handle unbuffering the warnings in that case, right?
Collaborator
Author
There was a problem hiding this comment.
If they call TORCH_WARN, then a cpp warning will be printed (in cerr).
ezyang
approved these changes
Oct 2, 2019
Fix for #25859 Differential Revision: [D17692504](https://our.internmc.facebook.com/intern/diff/D17692504) [ghstack-poisoned]
pytorchbot
added
the
module: internals
Fix for #25859 Differential Revision: [D17692504](https://our.internmc.facebook.com/intern/diff/D17692504) [ghstack-poisoned]
Fix for #25859 Differential Revision: [D17692504](https://our.internmc.facebook.com/intern/diff/D17692504) [ghstack-poisoned]
Fix for #25859 Differential Revision: [D17692504](https://our.internmc.facebook.com/intern/diff/D17692504) [ghstack-poisoned]
Fix for #25859 Differential Revision: [D17692504](https://our.internmc.facebook.com/intern/diff/D17692504) [ghstack-poisoned]
Fix for #25859 Differential Revision: [D18249631](https://our.internmc.facebook.com/intern/diff/D18249631) [ghstack-poisoned]
Fix for #25859 Differential Revision: [D18249631](https://our.internmc.facebook.com/intern/diff/D18249631) [ghstack-poisoned]
Fix for #25859 Differential Revision: [D18249631](https://our.internmc.facebook.com/intern/diff/D18249631) [ghstack-poisoned]
Fix for #25859 Differential Revision: [D18249631](https://our.internmc.facebook.com/intern/diff/D18249631) [ghstack-poisoned]
Fix for #25859 Differential Revision: [D18249631](https://our.internmc.facebook.com/intern/diff/D18249631) [ghstack-poisoned]
Fix for #25859 Differential Revision: [D18249631](https://our.internmc.facebook.com/intern/diff/D18249631) [ghstack-poisoned]
Fix for #25859 Differential Revision: [D18249631](https://our.internmc.facebook.com/intern/diff/D18249631) [ghstack-poisoned]
albanD
added a commit
to albanD/pytorch
that referenced
this pull request
Nov 6, 2019
ghstack-source-id: 4f84cb4 Pull Request resolved: pytorch#27154
Fix for #25859 Differential Revision: [D18249631](https://our.internmc.facebook.com/intern/diff/D18249631) [ghstack-poisoned]
Contributor
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #25859
Stack from ghstack:
Differential Revision: D18249631