[Reland] Fixed seek offset size to 64bit. #27125
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Fixes pytorch#26998 Pull Request resolved: pytorch#27047 Differential Revision: D17666050 Pulled By: ezyang fbshipit-source-id: f02ebd5320ae25f8949be20d0744fe3cd3e2fee9 (cherry picked from commit 1afe3fc) (cherry picked from commit 5846008)
pytorchbot
added
module: internals
pytorchbot
added
the
module: tests
Collaborator
Author
|
@ezyang The test passes and i will revert the unrelated changes. |
This reverts commit a4de98d.
Collaborator
Author
|
@pytorchbot rebase this please |
Contributor
|
Thank you for being on top of this. Waiting on CI to agree this works. |
ezyang
approved these changes
Oct 1, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
soumith
pushed a commit
that referenced
this pull request
Oct 4, 2019
* Fixed seek offset size to 64bit. (#27047) Summary: Fixes #26998 Pull Request resolved: #27047 Differential Revision: D17666050 Pulled By: ezyang fbshipit-source-id: f02ebd5320ae25f8949be20d0744fe3cd3e2fee9 (cherry picked from commit 1afe3fc) * Use _lseeki64 instead for MSVC (cherry picked from commit f49f78d)
pdlive215
pushed a commit
to pdlive215/pytorch
that referenced
this pull request
Nov 27, 2019
Summary: Fixes pytorch#26998. Pull Request resolved: pytorch#27125 Differential Revision: D17687154 Pulled By: ezyang fbshipit-source-id: 6784f4fd799130ac72a25884f120a0ba96bd4f51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26998.