Add C++ torch::nn::functional::pdist #27122
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yf225
reviewed
Oct 1, 2019
|
|
||
| /// Computes the p-norm distance between every pair of row vectors in the input. | ||
| /// This function will be faster if the rows are contiguous. | ||
| inline Tensor pdist(const Tensor& input, int64_t p = 2) { |
Contributor
There was a problem hiding this comment.
@jon-tow My sincere apologies - I made a mistake and just realized that p should be double type (https://en.wikipedia.org/wiki/Norm_(mathematics)#p-norm). Sorry for the inconvenience :(
Contributor
Author
There was a problem hiding this comment.
@yf225 Ah wow, good catch. I was also certain that p was integer rather than real.
Contributor
Author
|
@yf225 You're welcome! |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@yf225 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
pdlive215
pushed a commit
to pdlive215/pytorch
that referenced
this pull request
Nov 27, 2019
Summary: Adds `torch::nn::functional::pdist` module support for the C++ API. Issue: pytorch#25883, pytorch#27082 Reviewer: yf225 Pull Request resolved: pytorch#27122 Differential Revision: D17685823 Pulled By: yf225 fbshipit-source-id: f8ceb09635385ef2e16a002e5fc255be8eb2ebf4
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: Adds `torch::nn::functional::pdist` module support for the C++ API. Issue: pytorch#25883, pytorch#27082 Reviewer: yf225 Pull Request resolved: pytorch#27122 Differential Revision: D17685823 Pulled By: yf225 fbshipit-source-id: f8ceb09635385ef2e16a002e5fc255be8eb2ebf4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
torch::nn::functional::pdistmodule support for the C++ API.Issue: #25883, #27082
Reviewer: @yf225