Skip to content

Conversation

@pbelevich
Copy link
Contributor

@pbelevich pbelevich commented Sep 29, 2019

Stack from ghstack:

Differential Revision: D17682402

[ghstack-poisoned]
@pbelevich pbelevich requested a review from yf225 September 30, 2019 20:16
Copy link
Contributor

@yf225 yf225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pbelevich !

@facebook-github-bot
Copy link
Contributor

@pbelevich merged this pull request in 5005f7b.

@facebook-github-bot facebook-github-bot deleted the gh/pbelevich/23/head branch October 28, 2019 22:17
@yf225
Copy link
Contributor

yf225 commented Nov 14, 2019

@pbelevich Sorry I just realized that we didn't add a test for F::max_unpool3d in test/cpp/api/functional.cpp, curious would you like to add one? Thanks!

pdlive215 pushed a commit to pdlive215/pytorch that referenced this pull request Nov 27, 2019
Summary: Pull Request resolved: pytorch#27027

Test Plan: Imported from OSS

Differential Revision: D17682402

Pulled By: pbelevich

fbshipit-source-id: 2008ce405176c174cdba88b4f25cd77a82bb13ea
thiagocrepaldi pushed a commit to thiagocrepaldi/pytorch that referenced this pull request Feb 4, 2020
Summary: Pull Request resolved: pytorch#27027

Test Plan: Imported from OSS

Differential Revision: D17682402

Pulled By: pbelevich

fbshipit-source-id: 2008ce405176c174cdba88b4f25cd77a82bb13ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged module: cpp Related to C++ API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants